Giter Site home page Giter Site logo

Comments (10)

dereuromark avatar dereuromark commented on June 30, 2024

Do u want to make a PR removing all those property usage?
Or just adding the missing property?

from cakephp-queue.

dereuromark avatar dereuromark commented on June 30, 2024

The alternative I would prefer right now is to set the attribute for it.

#[AllowDynamicProperties]

This has less changes and thus less possible negative side effects for now.

from cakephp-queue.

mrothauer avatar mrothauer commented on June 30, 2024

Do u want to make a PR removing all those property usage? Or just adding the missing property?

This time, I prefer not to be involved in fixing my issue. If that's ok for you.

from cakephp-queue.

dereuromark avatar dereuromark commented on June 30, 2024

I started #389
I will see what can be done regarding the loadModel() calls.
Adding the property doesnt work and creates errors. So either we refactor fully or we need to silence the deprecations if attribute is there

from cakephp-queue.

dereuromark avatar dereuromark commented on June 30, 2024

https://github.com/dereuromark/cakephp-queue/releases/tag/6.8.0 should already help a bit with deprecations

from cakephp-queue.

mrothauer avatar mrothauer commented on June 30, 2024

Thanks. I updated my app but I still get the same deprecation message.

from cakephp-queue.

dereuromark avatar dereuromark commented on June 30, 2024

Well, the main issue wont go away unless we ship cakephp/cakephp#17383 and you use PHP 8.2+

The alternative would be to completely refactor away from properties and use fetchTable() everywhere, similar to what already done in 5.x version I assume.

from cakephp-queue.

mrothauer avatar mrothauer commented on June 30, 2024

Well, the main issue wont go away unless we ship cakephp/cakephp#17383 and you use PHP 8.2+

Ok, thank you for the clarification. I'll wait for that.

from cakephp-queue.

dereuromark avatar dereuromark commented on June 30, 2024

I am not sure it is gonna happen
You could backport similar changes as 7.0.0-RC...7.0.0 to Cake4 branch.
Then we can release a patch here.

from cakephp-queue.

mrothauer avatar mrothauer commented on June 30, 2024

If its fixed when I switch to CakePHP 5, thats fine for me. So I won't backport the changings.

from cakephp-queue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.