fix master, change docker tag to point to a working version

[derhuerst]

fix master, change docker tag to point to a working version

[deiga]

At least that seems to work now

[derhuerst]

Unfortunately master is currently broken. I haven't gotten around to fix it.

[deiga]

@derhuerst I understand that. Is there some automation to how the Docker images are pushed to DockerHub?
A first step would be to get a docker image tagged to version 2 and thus provide a working image

[derhuerst]

Is there some automation to how the Docker images are pushed to DockerHub?

Yep, the Docker Hub GitHub integration will build on every push to master.

The docker image is unusable, because it points to master and thus contains a load of broken code.

Now that I'm thinking about it: which feature do you mean?

[deiga]

Filtering stations doesn't work, there's multiple undefined references

_{Sent with GitHawk}

[deiga]

You should also be able to create automated build to dockerhub with:

• type: Tag
• Name: /^[0-9.]+$/
• Docket Tag Name:

This would build and tag an image with any git tag, that way there would be a working image available :)

[derhuerst]

Filtering stations doesn't work, there's multiple undefined references

Please provide more details.

[deiga]

@derhuerst

• allStations is undefined https://github.com/derhuerst/vbb-rest/blob/master/lib/stations.js#L57
  • After fixing the reference the loop doesn't work right

[derhuerst]

I've fixed this in e2ae7ce and reverted 95fd163 because hafas-client-rpc is only compatible with hafas-client@3 (this API uses hafas-client@2).

Please try the new docker image (cf5d969cbc9d).

[deiga]

http://localhost:3000/stations?coordinates.latitude=52.533387=> { "error": true, "msg": "Cannot convert undefined or null to object" }

[derhuerst]

Fixed more in 5f6786f. 😛 Really haven't focused enough on vbb-rest in the past months as it turns out.

Please wait for the Docker Hub build. The new image is dc0f33b8a124 .