Giter Site home page Giter Site logo

Comments (6)

shiftkey avatar shiftkey commented on August 19, 2024

@ottosson thanks for the report! I'm not sure offhand because I thought #165 would address this, and it was included with 1.8.0 which you seem to be using.

Check you don't also have a node-abi dependency in your project that might be older than the current version. If you do ensure that you bump it to 2.10.0 which contains the Electron 6 update.

from registry-js.

ottosson avatar ottosson commented on August 19, 2024

I don't have node-abi in my package.json

from registry-js.

ottosson avatar ottosson commented on August 19, 2024

Ok so coming back to this issue again I tried to add node-abi (currently 2.11.0) as a dependency for my project and it works! I thought the node-abi would be added by another dependency, (maybe registry-js?), but it seems I was wrong. This fixes the issue for me.

Closing!

from registry-js.

shiftkey avatar shiftkey commented on August 19, 2024

@ottosson

I thought the node-abi would be added by another dependency, (maybe registry-js?), but it seems I was wrong.

It does exist as a dependency of prebuild-install - here's the version I got when installing into electron-quick-start:

$ npm ls node-abi
[email protected] /Users/shiftkey/src/electron-quick-start
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

But this dependency is a pretty relaxed version range:

    "node-abi": "^2.7.0",

What I believe was happening was that something else in your project had it's own node-abi dependency, and that older version was being used after upgrading to Electron 6 due to how npm de-dupes dependencies and the relaxed version constraint.

Anyway, overriding it by choosing the latest version in your project is the recommended option here - I'm glad you were able to find a workaround!

from registry-js.

ottosson avatar ottosson commented on August 19, 2024

Ah, makes sense! Thanks for the explanation.

from registry-js.

yagoubigithub avatar yagoubigithub commented on August 19, 2024

update node-abi work for me
yarn upgrade node-abi
or
npm update node-abi

from registry-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.