Address double-cast in ReadValues

[desktop]

Address double-cast in ReadValues

[danilaml]

@shiftkey btw, any reason HKEY enum holds strings, instead of values directly? Wouldn't need the clumsy mapToLong that way. (I've also found this package that does similar stuff: https://github.com/CatalystCode/windows-registry-node )

[shiftkey]

btw, any reason HKEY enum holds strings, instead of values directly?

Convenience mostly. A string is a bit more readable for the caller to manage, so this:

import { enumerateValues, HKEY } from 'registry-js'

const values = enumerateValues(
  HKEY.HKEY_LOCAL_MACHINE,
  'SOFTWARE\\Microsoft\\Windows\\CurrentVersion'
)

Could just be written as this in JS (for callers who import this without having the TypeScript declarations available):

import { enumerateValues } from 'registry-js'

const values = enumerateValues(
  'HKEY_LOCAL_MACHINE',
  'SOFTWARE\\Microsoft\\Windows\\CurrentVersion'
)

[danilaml]

@shiftkey well, not sure if it's a good choice when the input value is an enum, i.e. can only be something of few predefined types. This saves only 3 chars to type but makes it easier to make a mistake, IMHO (in both, userCode and mapToLong). But whatever, I don't mind. Just asked)

[shiftkey]

@danilaml no problem at all - it's early days for this and I'm basing this off my experiences working with the registry...

[j-f1]

@shiftkey enums appear in the compiled JS:

// from:
enum Foo {
  A = 'A',
  B = 'B',
  C = 'C',
}

// to:
var Foo;
(function (Foo) {
    Foo["A"] = "A";
    Foo["B"] = "B";
    Foo["C"] = "C";
})(Foo || (Foo = {}));

(see it live)