Giter Site home page Giter Site logo

Comments (7)

mapmeld avatar mapmeld commented on June 12, 2024

I've updated the README on NPM and GitHub so it'll be clear that it's a fork.
We'll revisit the possibility of describing our changes and contributing back in Jan 2024

from determined.

jassmith avatar jassmith commented on June 12, 2024

I really appreciate the prompt response. Especially considering how close to christmas we are.

from determined.

jassmith avatar jassmith commented on June 12, 2024

Can you explain the intent of this diff maybe? glideapps/glide-data-grid@4c94ecd?diff=split&w=0

I see the message but I cannot see how the diff enables that.

from determined.

mapmeld avatar mapmeld commented on June 12, 2024

I think the issue there is defaultSize (150px) is returned for the width for any GridCellKind.Custom , instead of allowing these types to call r?.measure?. Should they be overriding something else?
I'm getting more info about the other line there, if we have any reason to expect a 0 width which we override using || instead of ?? there.

Doing the diff, the only other changes are resizing columns determined-ai/glide-data-grid#3 and middle mouse button check determined-ai/glide-data-grid@ab22e79

from determined.

jassmith avatar jassmith commented on June 12, 2024

The last 2 you mentioned are already taken back to the mainline branch. The one in question I see the problem with. I will get a fix in ASAP.

from determined.

jassmith avatar jassmith commented on June 12, 2024

I've validated that the defaultSize is not an issue in the 6.0.0 series. You should be able to move back to the stable mainline. There is a release candidate available now as 5.99.9-rc2 right now.

from determined.

mapmeld avatar mapmeld commented on June 12, 2024

Thanks! I've opened a PR to upgrade to 6.0.0, so closing this issue.

from determined.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.