Giter Site home page Giter Site logo

Comments (2)

developit avatar developit commented on May 18, 2024

Hi @gluck - the issue is more that npm itself doesn't support peerDependencies in sub-packages. The fact that we have a peerDep for preact at the root is mostly due to htm previously only shipping a Preact variant. As far as I'm aware, the only solution here to avoid everyone getting warnings in their console when installing is simply to remove the peerDependencies altogether.

from htm.

gluck avatar gluck commented on May 18, 2024

Hi ! Thanks for the fix at root level.
Right now npm mostly ignores sub-packages entirely, no ? (only the bundler, or node, or whoever resolves the import statement cares)
I'd add the peerDep on sub-package, because that's how it'd be if the package was shipped on its own (e.g. lerna ?), but I don't think anyone really cares today.

Cheers.

from htm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.