Tab completion for nickname

[devleoko]

Tab completion for nickname

[ZombieHDGaming]

I made a new build here:
REMOVED FOR INVALID REPOSITORY USED

Sorry the size is a tad bit bigger than Leoko's normal builds, he most likely has a program compress the JAR farther than what I have my Eclipse compiler set to. Also sorry for using MediaFire :P

If there are any errors, let me know and I will attempt to fix them.

[mdcfe]

@Twonox

AdvancedBan/src/me/leoko/advancedban/bungee/listener/CommandReceiverBungee.java

Line 25 in 99c3188

return BungeeMain.get().getOnlinePlayers();

This is probably intended. Rather than filtering players, it just tab completes using a list of all players. It's not a bug as such, but could probably be improved.

[ZombieHDGaming]

Since someone will eventually ask you this, are you using this on Bukkit/Spigot or BungeeCord, because your server version is a bit confusing.

If you are using Bukkit/Spigot, I will look into this and try to find the issue and make a pull request. If you are on BungeeCord, I will still try and find the issue, but I may not be able to help you as I am not that experienced with BC. I would also check your server settings, and plugins, for anything to do with tab completion, as this may also cause an issue.

[mdcfe]

@ZombieHDGaming I assumed he was running AB on the server which was behind BungeeCord.
In Bukkit and Spigot it is impossible to globally override tab completion for all commands; plugins can only do it per-command and there are no "settings" for it. BungeeCord usually passes tab completion through to the server unless it is disabled, in which case it won't work at all.

Regardless, I can confirm that this has been an issue on Paper 1.11.2, which also doesn't alter tab completion behaviour as far as I know.

@Twonox Could you paste a list of plugins you are running?

[Twonox]

I use Ab with bungee, not in single server.

Plugins: https://hastebin.com/gomaxusawo.nginx

[mdcfe]

What Bungee plugins are you running?

[Twonox]

AdvancedBan, BungeeAuthmeBridge, BungeeMotd, Bungeeperms, CommandDispatcher, SkinRestorer and Socket4MC

[ZombieHDGaming]

@md678685 Actually, there is an event for tab completion to prevent it, and edit the completions, I am currently testing other commands for custom completions. Also, your bug confirmation is actually null. I just tested AdvancedBan 2.0.6 on the latest Spigot and PaperSpigot, freshly built, and tab complete works fine for players. As for you @Twonox, this is an interesting situation. I have not tested BC AdvancedBan yet, but I will have to test it and see if I get the same result as you do.

So yes. Current Standing: Spigot/PaperSpigot/Bukkit are fine, BungeeCord is still currently unknown. I think this is safe to say, this is a per-server error basis.

[ZombieHDGaming]

I made a PR to hopefully make a quick fix for this, and hopefully prevent something like this in the future. If this gets pulled in, it should fix your issue :)

[dutchy1001]

Can this fix also use tab completion for offline players when in the data base (either data.yml or MySQL)?

[ZombieHDGaming]

Currently, it does not. My pull was just a rewrite for the original tab complete to add for already typed text completion for online players. Again, as I don't know much about BungeeCord I could not say if I could do this. Although, if other devs wanted to try their hand in this, they most likely could try and modify my PR to add that feature.

[DevLeoko]

The PR got merged after some imporvements on the code ;) thanks @ZombieHDGaming

Advanced Tab Completion for offline players, layouts, time types etc. will be added in a future version of advancedban :)

[Twonox]

Is there dev build of this update please ?

[DevLeoko]

No sorry, but the code is public so feel free to compile it by your own

[Twonox]

Erf, I tried to compile Ab with Eclipse and its Git perspective but when I try to create the Java project from the ab git files I receive this error: https://hastebin.com/amaciyozuk.pl
I did successfully the clone of the ab repo, idk why there is this error.

[ZombieHDGaming]

I am currently out, but when I get home, I'll have a Crack at compiling AB.

[Twonox]

I've tested the tab completion, but it sadly doesn't work :/

[ZombieHDGaming]

Is it at least tabbing properly? Or is it like it was before?
EDIT: Nvm, I dowloaded the master repository by accident :P

[ZombieHDGaming]

Okay, I NOW have the proper build done. This should fix tab completing and any fix that was added in the last few days.

AdvancedBan V.2.0.6.1
https://www.mediafire.com/?vz35d9canl86e1q

[Twonox]

Thanks but my antivirus say that it's can malicious. Should I trust you ? :o x)

[ZombieHDGaming]

What virus protection do you use? Also, you can decompile if you would like and look. I do not even know where to start with hacking, so I wouldn't be able to do anything.

But yes, I have done nothing with the source files besides a few clean ups.

[Twonox]

I use McAfee WebAdvisor

[ZombieHDGaming]

Word of advice, never use McAfee. I would suggest Norton as a better option. While Norton is a yearly thing, it has better detection than McAfee ever will. Plus McAfee has been known for it's false detections, or no detections at all for high risk files.

This is the result from an online file scanner. 41 engines and no threats detected.
https://www.metadefender.com/#!/results/file/YTE3MDEzMXJKb0dJVVJCUkRsckpoTTg4Q3JSRGU/extracted/files

[dutchy1001]

Neither anti virus programs I will ever recommend.
As McAfee in know for false detection, Norton slows your pc down (they probably both do). 1 other bad point is that both have to be paid for.
Avast or AVG both have free versions that do just as good, or even better then McAfee or Norton.

[Twonox]

I use McAfee for only Web protection.
The antivirus that I use for my computer is Windows Defender. I know, the antivirus make the computer more slow, for this reason I deleted McAfee a long time ago.
But also now, I deleted Mcafee Web Advisor for false danger detection. I'm open to your suggestion for only Web protection

[Twonox]

I tested your update ZombieHDGaming, and I'm happy to say that IT WORKS ! :p thank you again

[ZombieHDGaming]

For just web protection, that's hard to say. Web protection isn't exactly a very high priority, as your virus software and browser mainly scan for this. If anything, I would say just use your normal system protection for this. Also, you are welcome. Let me know if there is anything else you want tweaked, and I will look into getting it done.

[Twonox]

Mhmm, I have an other (very little) request, at the moment. It's to add /banip because there is only /ipban which works,

[ZombieHDGaming]

@Twonox banip is already implemented as an alias. Have you tested this to see if it works? If not, I will most likely have to figure out a fix and push a PR to fix it on here as well.

[dutchy1001]

You have to add - banip also to the essentials config "disabled-commands" section or it will interfere with AdvancedBan.

[Twonox]

I will test your suggestion dutchy, but I don't understand why ab's /banip can have interference with essentials whereas the other commands works fine.

[dutchy1001]

This is what I experienced before and adding that to the essentials file fixed it for me.
I think it used the essentials ipban instead of the Advancedban.

[dutchy1001]

When using the command /ipban it used the essentials version.
When using the command /banip it used the AdvancedBan version.
For ease you type /ipban faster then the otherway around lol

[Twonox]

/ipban is handled by Ab, not by essentials

[dutchy1001]

It could be a leftover setting from when I uses v10.3. It just popped up in my mind when you asked for adding the command. If all works fine without it been added to the essentials config then forget I said some.
Better to much info then to less 😜

[Twonox]

I did the test in my test server, and I noticed that the command /banip works fine only if Ab isn't in BungeeCord.

[dutchy1001]

Then when placed in the bungeecord Essentials takes over as this is on the server and not in your bungee.
If you test it with bungee and add the command to the "disabled-commands" it should work fine again.

[Twonox]

Ok, now i'm not able to test. I give news tomorrow

[dutchy1001]

no worries

[Twonox]

I did what you said but it completely disable the command /banip

why ab's /banip can have interference with essentials whereas the other commands works fine.

It seemed evident that is not the cause.

[dutchy1001]

Indeed the command does not do anything atm, I just tested this too. But to be honest I type /ipban as I'm used to that command and it feels allien to type it the otherway.

[DevLeoko]

Well, it seems like the aliases are not working in BungeeCord :D I'm normally only coding Spigot/Bukkit Plugins so I did not know about this ^^ I'll fix it in a future version

[ZombieHDGaming]

@DevLeoko aka, I'll most likely make a PR for it....

[dutchy1001]

Hows the tab completion error coming along? any more news or tests on it??

[ZombieHDGaming]

The tab completion was confirmed as fixed, unfortunately, the aliases for BungeeCord may be out of reach due to how AdvancedBan is currently setup. As all the commands are not currently a "solid state (hard coded into system)," a full rewrite of the BungeeCord command system may need to happen for aliases to work properly.

[dutchy1001]

that conformation was only made on your build as far I understand, has there been a PR made for a new version that can be released by Leoko?

[ZombieHDGaming]

I just looked inside the PR section, and the last PRs were made by myself, nearly 2 weeks ago.

[dutchy1001]

So it's just waiting for a new release then...