Comments (1)
Elessar1802
commented on August 9, 2024
Fixes done -
- Pagination breaks on search in resource browser K8sResourceTab
- App Details view react select z-index
- Double separators in dynamic tabs (UI bug)
- Cluster Overview (dc__overflow) added to the tiles so that it doesn't break on smaller screens
- Using registerShortcut from fe-common-lib
- K8sResourceList shortcut key disappears after search/clear
- Search all fields in resource list data instead of specific fields
- ClusterTerminal doesn't show loading when the /user/terminal/start call takes too long
- ClusterTerminal throws toasts on abort (IMO it shouldn't need to verify with Utkarsh)
- App Details dynamic tabs multiple borders
Refactorings -
- reduced explicit useStates from 33 to 3 in ResourceList.tsx
- Reduced useEffects from 10 to 3
- Removed url based logic (using useEffect) to dictate dynamic tabs selection to user interaction based since it was too convoluted and incorrect
- Broke down ResourceList.tsx into 2 new files - K8sResourceTabComponent.tsx and AdminTerminalComponent.tsx.
Impact: This has significantly reduced the LOC in each file leading to reduced cognitive load on the developer and also reduced prop drilling significantly. Also lead to nice :) separation of concern
from dashboard.
Related Issues (20)
- Migrate useAsync, copyToClipboard to common-lib
- Fix: Deploy Chart visibility on Readme and Compare Values selection
- Cancel token implementation in Deployment template, ConfigMap and Secrets
- feat: add support for ssh tunnel
- Retain Default Terminal session of cluster in Resource Browser
- App list filter spacing and Protect configuration background colour
- App list filter spacing and Protect configuration background colour
- Follow-up bugs after retaining Cluster Terminal in Resource Browser
- New App Details Cards on App Details
- Pod terminal tab getting stuck
- Sorting event data based on the lastTimeStamp
- select button is not disabled is case of image scanning & In app details page , app status message is wrong
- Enhancement: Hide the details configured in LDAP of SSO login service
- Bug: Build & Deploy page breaks when git-sensor mvc is down due to some reason and also toast (with proper reason) does not appear.
- FE: Enhance the buildx to use cache for multi arch builds
- Artifact repo path and helm chart should be visible .
- List of repo there is an issue if any new user came how he knows user_handle/repo_name
- Vulnerability scanning UI is breaking.
- bug: text fix in case of registry
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dashboard.