Comments (10)
Oops, forgot to regenerate that patch. Updated patch attached.
Original comment by [email protected]
on 31 Jul 2010 at 7:02
Attachments:
from angleproject.
Daniel, Alok, can one of you take this bug and integrate this patch?
Original comment by [email protected]
on 2 Aug 2010 at 4:52
from angleproject.
i'll review it
Original comment by [email protected]
on 2 Aug 2010 at 5:15
from angleproject.
Hi Vlad,
* The actual change themselves seem fine, however it seems they go too far
for just supporting EXT_texture_format_BGRA888
* the spec doesn't say this extension extends glCopyTexImage2D to support
this. It's possible it is supposed to be implied since CopyTexImage2D
formats are defined in terms of TexImage2D, but I'm going to ask on the ES
mailing list for clarification from existing implementors.
* the extension doesn't extend the supported read formats for ReadPixels.
It would need to support something like EXT_read_format_bgra to expose this
functionality. However EXT_read_format_bgra also exposes the
UNSIGNED_SHORT_4_4_4_4_REV_EXT and UNSIGNED_SHORT_1_5_5_5_REV_EXT types as
possible combinations with the BGRA_EXT format.
* the alternative is writing an ANGLE-specific extension which adds all
of this functionality.
Daniel
Original comment by [email protected]
on 4 Aug 2010 at 6:59
from angleproject.
Ah, good point; I made the CopyTexImage2D assumption, and I wasn't thinking in
terms of the read format for ReadPixels. I could also just add support for
UNSIGNED_SHORT_4_4_4_4_REV_EXT and UNSIGNED_SHORT_1_5_5_5_REV_EXT fairly
easily, to avoid having to define a new extension for this; would that be
better?
Original comment by [email protected]
on 4 Aug 2010 at 7:05
from angleproject.
Yes, that seems reasonable.
Original comment by [email protected]
on 4 Aug 2010 at 7:14
from angleproject.
Consensus is that the CopyTexImage2D does not accept the BGRA_EXT token for
<internalformat>.
EXT_texture_formatBGRA8888 appears to be purely for the convenience for loading
textures from client memory and doesn't really add a new internal format, it
behaves like any other RGBA texture.
Original comment by [email protected]
on 5 Aug 2010 at 12:56
from angleproject.
Ok, updated to remove the CopyTexImage2D bit, and to fully implement
EXT_read_format_bgra.
Original comment by [email protected]
on 7 Aug 2010 at 4:05
Attachments:
from angleproject.
Patch looks good with the following exceptions:
* unused finish: label was added (I've removed it).
* I'm fairly certain the component orderings for GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT and GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT were backwards, so I fixed them and added in comments explaining the bit ordering. Please let me know if you disagree and/or have tests which prove otherwise.
Changes committed @ r370
Original comment by [email protected]
on 8 Aug 2010 at 4:52
- Changed state: Fixed
from angleproject.
Great, thanks -- yeah, missed the finish label (was part of something else that
snuck in).
For the component ordering, you're probably right; I started at the docs for a
while, but I had a hard time finding code that actually used either of those,
so couldn't find a concrete example to check expectations.
Original comment by [email protected]
on 8 Aug 2010 at 6:43
from angleproject.
Related Issues (20)
- ANGLE_instanced_arrays produces garbage vertex data when there are more instances than vertices and non-overlapping parts of buffers are updated. HOT 6
- Do not fail preprocessing with float/int literal overflows HOT 1
- Fix compile errors in essl to hlsl project introduced by shader lang API change HOT 6
- Image11::generateMipmaps maps source texture as D3D11_MAP_WRITE HOT 6
- Expose the packing function so we can check varyings packing per program HOT 1
- Set gl_Position if it's missing in vertex shader HOT 3
- VS build broken HOT 4
- Why use a hash for name mangling? HOT 7
- Support the Windows 8 SDK for shader generation with fxc HOT 4
- Add end-of-line normalization control with gitattributes HOT 4
- Syntax errors and wrong translator name in gyp build scripts HOT 8
- RTTI compilation regression with gcc compilation fixes HOT 2
- DX11 breaks autofocus in WebGL demos HOT 2
- Fix incorrect khrplatform.h typedefs for Win64 HOT 2
- Swap chain reset/swap interval change incorrectly shortcutting HOT 2
- Add an compile option to work around short-circuit condition bug HOT 2
- Investigate behavior of cube textures specified as texture 2D arrays in SRVs on older systems
- Rename ParseHelper.cpp/h to ParseContext.cpp/h HOT 2
- Vertex conversion detection in DX9 is incorrect HOT 2
- D3D9 Compiler optimization bug causes issues with short-circuiting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angleproject.