Giter Site home page Giter Site logo

Memory Leak? about rxtodo HOT 4 CLOSED

devxoul avatar devxoul commented on May 20, 2024
Memory Leak?

from rxtodo.

Comments (4)

devxoul avatar devxoul commented on May 20, 2024 2

@reejosamuel, RxTodo is the most up-to-date code. Drrrible and Cleverbot will be updated soon :)

It's true that more enum cases can cause more complexity. But it has same complexity compare to the current architecture (Observables per each input/output). The most benefit of using enums is that compiler can validate unused/misused cases.

from rxtodo.

reejosamuel avatar reejosamuel commented on May 20, 2024 1

I tried the new action-state architecture you proposed. in the todo app i don't see any leaks at all when I open and close next view controllers. But in the dribbble one with the new architecture i still see some mismatch.

With the new architecture one thing I noticed is that the cyclometric complexity of a function can increase quite a bit in a larger application because of using so many switch cases. I was thinking how we could improve so many switch cases in the mutate and transform methods but overall it seems like much more single responsibility, easier to read and functional than earlier.

from rxtodo.

devxoul avatar devxoul commented on May 20, 2024

Not sure but there might be memory leaks. I'm currently working on a new code base(#19) which doesn't have memory leaks at all :)

from rxtodo.

seivan avatar seivan commented on May 20, 2024

@reejosamuel Nothing prevents you from breaking down your reducer into smaller reducers.
Your enum can contain other actions. I think that's how Elm-lang does it and Redux has its combineReducer()

from rxtodo.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.