Comments (5)
Many thanks for this report! Honestly, I still have to find the problem. The input is fine, and I can reproduce the error. Once I know more I let you know
from sqsgenerator.
Many thanks for this report! Honestly, I still have to find the problem. The input is fine from the input, and I can reproduce the error. Once I know more I let you know
Thank you very much for your reply! I think the difference may be due to the formula. The theoretical SRO formula is α=1-(Pij/Cj), where Pij is probability of j around i atom, and Cj is concentration of j. Taking 1st nearest neighbor as an example.
(1) For pure Ni (fcc), the theoretical SRO is 1-1/1=0. For your formula, the SRO of Ni-Ni is α=1-(12/2 N)/(N * 12 * 1 * 1)=0.5.
(2) For Ni3Al (L12), the theoretical SRO of Ni-Ni is 1-(2/3)/(3/4)=1/9. For your formula, the SRO of Ni-Ni is α=1-3N/(N * 12 * 0.75 * 0.75)=5/9. There are 6N bonds in Ni3Al (L12), 3N for Ni-Al, and 3N for Ni-Ni.
By the way, how to cite your code? Have you published papers by using this code.
Thank you!
from sqsgenerator.
The reason why the the value is wrong is that the computation of the occupations of the coordination shells is "wrong".
The programm basically creates a histogramm of the distance matrix, to determine how many atoms are in the individual coordination shells. As in this small cell there are only 4 atoms, all the other three atoms are in the first coordination shell. Therefore, we get with 3 Ni-Ni bonds, α=1 - 3/(4 * 3 * (3/4)^2) = 1 - 4/9 = 5/9 = 0.55555555559. This is how we get to this wrong answer.
The reason why that is so is that, we usually deal with super-cells where this case does never happen (for us at least).
By the way, how to cite your code? Have you published papers by using this code.
Actually not yet! I'm working on it! I'm intensively working on a new version of it where I want to fix all those problems
from sqsgenerator.
Great! Looking forward to your excellent job!
In other words, at present, this code can correctly deal with the short-range order of A-B bonds when A and B are different, is it right?
For Ni3Al, I use 108-atom (3 * 3 * 3) supercell, and the result is same.
from sqsgenerator.
For Ni3Al, I use 108-atom (3 * 3 * 3) supercell, and the result is same.
Indeed I can confirm that
I think the difference may be due to the formula. The theoretical SRO formula is α=1-(Pij/Cj), where Pij is probability of j around i atom, and Cj is concentration of j. Taking 1st nearest neighbor as an example.
(1) For pure Ni (fcc), the theoretical SRO is 1-1/1=0. For your formula, the SRO of Ni-Ni is α=1-(12/2 N)/(N * 12 * 1 * 1)=0.5.
(2) For Ni3Al (L12), the theoretical SRO of Ni-Ni is 1-(2/3)/(3/4)=1/9. For your formula, the SRO of Ni-Ni is α=1-3N/(N * 12 * 0.75 * 0.75)=5/9. There are 6N bonds in Ni3Al (L12), 3N for Ni-Al, and 3N for Ni-Ni.
I also double checked that. Tt seems that you were right! I do get one half for the pure systems
So I have to correct myself as it seems the the computation of the shell occupation is alright, and the difference comes from, as you already said, the different definition
from sqsgenerator.
Related Issues (14)
- License
- progress bar HOT 1
- Issue with building sqsgenerator
- Configurational entropy HOT 1
- How to check the number of A-B bonds in sqsgenerator HOT 1
- Errors in running the simple example provided by the tutorial website HOT 6
- Thread Limit HOT 1
- Issue with ASE structure conversion HOT 3
- Number of A-B bonds for (111)-oriented supercells of N3Al HOT 3
- Feature Information HOT 10
- Valueerror on unspecified file (here: POSCAR) HOT 3
- setting up the composition flag correctly HOT 1
- Defining sublattice composition HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqsgenerator.