`Goto site` step in the browser steps doesn't work even though it is part of the steps.

[manojVivek]

`Goto site` step in the browser steps doesn't work even though it is part of the steps.

[dgtlmoon]

fantastic report, thanks! will check it out

[manojVivek]

Create a browser steps workflow with the following steps: Step 1: Goto site Step 2: Click element containing text "Login" Step 3: Enter text in field ".username" "some-username" Step 4: Enter text in field ".password" "some-password" Step 5: Click element button.login Step 6: Goto site Step 7: Click element containing text "show data"

why are you even using "goto site" as the first step?

I'm not using that, I referred this default "Goto Site" step:

[manojVivek]

@dgtlmoon If you are fine with the following fix, I can try and make a PR if you are fine with the following fix:

1. Filter out the Goto site step only when it is at Step 1.
2. Swap any other Goto site action to Goto URL, watch.url.

Please let me know your thoughts.

[dgtlmoon]

@dgtlmoon If you are fine with the following fix, I can try and make a PR if you are fine with the following fix:

1. Filter out the Goto site step only when it is at Step 1.
2. Swap any other Goto site action to Goto URL, watch.url.

Please let me know your thoughts.

yeah goto site should be the first step always

Goto URL should be every other step

problem is you'll also need to create an update hook so that you dont break everyones installations if you simply rename the step...

[manojVivek]

problem is you'll also need to create an update hook so that you dont break everyones installations if you simply rename the step...

No, I didn't mean to replace all Goto site to Goto URL in the datastore. All other Goto site will still be the same in the datastore.

But during the execution, we can do an inline conversion of all non-first-step Goto site into Goto URL with watch.url as arg like in

changedetection.io/changedetectionio/blueprint/browser_steps/__init__.py

Lines 170 to 173 in ee52947

	if step_operation == 'Goto site':
	step_operation = 'goto_url'
	step_optional_value = datastore.data['watching'][uuid].get('url')
	step_selector = None

Wdyt?

[manojVivek]

I have implemented the above explained approach in this PR #2337, and it worked well for the use case that was failing for me before.

[dgtlmoon]

Create a browser steps workflow with the following steps:
Step 1: Goto site
Step 2: Click element containing text "Login"
Step 3: Enter text in field ".username" "some-username"
Step 4: Enter text in field ".password" "some-password"
Step 5: Click element button.login
Step 6: Goto site
Step 7: Click element containing text "show data"

why are you even using "goto site" as the first step?

[dgtlmoon]

should be resolved with the PR