Giter Site home page Giter Site logo

Comments (6)

dherault avatar dherault commented on June 7, 2024

Ok I'm on it, expect v2.3.1 by the end of the day :)

from serverless-offline.

dherault avatar dherault commented on June 7, 2024

Done! Please enjoy v2.3.1 and tell me if it worked :)

from serverless-offline.

arabold avatar arabold commented on June 7, 2024

Thanks! It works perfectly for dynamic Content-Type headers now. But it seems there's one case that still doesn't work - fixed strings like this:

        "default": {
          "statusCode": "200",
          "responseParameters": {
            "method.response.header.Content-Type": "'text/html'"
          },
          "responseModels": {},
          "responseTemplates": { "application/json": "$input.path('$')" }
        }

In this case the plugin sets the Content-Type to 'text/html' (with single quotes around it). The correct value would be text/html (without quotes).

from serverless-offline.

dherault avatar dherault commented on June 7, 2024

Doesn't the unquoted version work on APIG? Please do not close this issue, I'll work on it later, thanks for the help @arabold !

from serverless-offline.

dherault avatar dherault commented on June 7, 2024

Done! See v2.3.2.

from serverless-offline.

arabold avatar arabold commented on June 7, 2024

The unquoted version wouldn't work as APIG needs to distinguish between a hardcoded value ('text/html') and a dynamic one (integration.response.body.contentType). The latest version works perfectly though! Thanks again.

from serverless-offline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.