Giter Site home page Giter Site logo

Comments (14)

dhowe avatar dhowe commented on August 29, 2024

Currently we are attempting to cancel all requests that we identify as audio/video/itunes/etc, but this needs much more thought/work

from adnauseamv1.

mushon avatar mushon commented on August 29, 2024

why not have js simply delete any embed / object / video / audio tag from the pages within the hidden iframes? Can this cascade into the iFrames within those hidden iFrames?

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

"[W]hy not have js simply delete any embed / object / video / audio tag from the pages within the hidden iframes"?

Easier said than done I think... Do we have any example of a plugin that does this? Certainly there are flashblockers, but we've also talked about wanting 'grab' animated ads of different types for the adview... I'm currently using regexs to cancel these (sub)requests, but they simple/stupid at the moment, and things get through (clearly, see issue #16)...

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

Log from a case where this occurred:

[23:16:51:383] TRYING: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box2&sn2=2f689ef3/3b4775dc&sn1=7441b9be/43ec397d&camp=inyt2013_120x90_digi_glob_3LUWH&ad=3LUWH_120x90_digi_glob&goto=http%3A%2F%2Fwww%2Einyt%2Ecom%2Fsubscriptions%2Finyt%2Flp3KYXX%2Ehtml%3Fadxc%3D232691%26adxa%3D359250%26page%3Dwww.nytimes.com/pages/realestate/index.html%26pos%3DBox2%26campaignId%3D3LUWH

[23:16:52:383] Cancelled(/video/i) -> http://www.inyt.com/subscriptions/inyt/img/icon-video.gif

[23:16:54:004] VISITED: http://www.inyt.com/subscriptions/inyt/lp3KYXX.html?adxc=232691&adxa=359250&page=www.nytimes.com/pages/realestate/index.html&pos=Box2&campaignId=3LUWH
Redirected-from: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box2&sn2=2f689ef3/3b4775dc&sn1=7441b9be/43ec397d&camp=inyt2013_120x90_digi_glob_3LUWH&ad=3LUWH_120x90_digi_glob&goto=http%3A%2F%2Fwww%2Einyt%2Ecom%2Fsubscriptions%2Finyt%2Flp3KYXX%2Ehtml%3Fadxc%3D232691%26adxa%3D359250%26page%3Dwww.nytimes.com/pages/realestate/index.html%26pos%3DBox2%26campaignId%3D3LUWH

[23:17:02:511] TRYING: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Frame3B&sn2=ed3abcee/153b086d&sn1=21bb5873/37806ffb&camp=Urbana_Propertie_1862311_Broker_Button-cla&ad=urbana-120x90-Banner_g.gif&goto=http%3A%2F%2Fwww%2Eurbanaproperties%2Ecom%2F

[23:17:16:330] VISITED: http://urbanaproperties.com/
Redirected-from: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Frame3B&sn2=ed3abcee/153b086d&sn1=21bb5873/37806ffb&camp=Urbana_Propertie_1862311_Broker_Button-cla&ad=urbana-120x90-Banner_g.gif&goto=http%3A%2F%2Fwww%2Eurbanaproperties%2Ecom%2F

[23:17:24:541] TRYING: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box1&sn2=2f689ef2/b4775dc&sn1=bff00d48/14532819&camp=nyt2014_300x250_module_chickenstew_hp_ros&ad=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114&goto=http://nytimes.com/video/dining/100000002642899/chicken-stew-with-sweet-plantains.html%3FWT.mc_id=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114-PH%26WT.mc_ev=click%26WT.mc_c=235247

[23:17:24:543] Cancelled(/video/i) -> http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box1&sn2=2f689ef2/b4775dc&sn1=bff00d48/14532819&camp=nyt2014_300x250_module_chickenstew_hp_ros&ad=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114&goto=http://nytimes.com/video/dining/100000002642899/chicken-stew-with-sweet-plantains.html%3FWT.mc_id=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114-PH%26WT.mc_ev=click%26WT.mc_c=235247

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

need a test-case for this

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

This should be fixed (once and for all) by disallowing plugin permissions on the (click) page-worker

from adnauseamv1.

mushon avatar mushon commented on August 29, 2024

Cool, does your code also prevent html5 video and audio there?

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

good point -- we'll have to test this...

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

closing for now, can re-open if we find another case

from adnauseamv1.

mushon avatar mushon commented on August 29, 2024

This ad played audio in the background (FF 33.1, ADN 1.0.05):

==========================================================================================
[5:49:31 PM:650] TEXT-AD: #890005 Ultimate Detangling Brush/www.MyNoTangleBrush.com/Michel Mercier's Brush Works On All Types of Hair! Now Get 2 for $14.95
==========================================================================================
[5:49:32 PM:639] TRYING(#890005): http://1641040.r.msn.com/?ld=d3ATGkt4INmPh1Lt1iaelT-TVUCUwdU9nR-MwkYaaapnosUbgsSfocyZqmMV6uyI0NXAkVddFhaRPfS9W93XQdxgHOwpXq6XpND3kswjd85uhwvezfnjAM9A-bRrZlJ9abZmkx7TWYOm-fHOZ6QulO4VqG0wU&u=https%3a%2f%2fwww.mynotanglebrush.com%2f%3fMID%3d6159551
==========================================================================================
[5:49:37 PM:771] VISITED(#890005): https://www.mynotanglebrush.com/?MID=6159551
               Redirected-from: http://1641040.r.msn.com/?ld=d3ATGkt4INmPh1Lt1iaelT-TVUCUwdU9nR-MwkYaaapnosUbgsSfocyZqmMV6uyI0NXAkVddFhaRPfS9W93XQdxgHOwpXq6XpND3kswjd85uhwvezfnjAM9A-bRrZlJ9abZmkx7TWYOm-fHOZ6QulO4VqG0wU&u=https%3a%2f%2fwww.mynotanglebrush.com%2f%3fMID%3d6159551
==========================================================================================```

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

Here's another case:
http://bellroy.com/wallets/travel-wallet?utm_source=Google&utm_medium=display&utm_campaign=Display%20|%20AU&gclid=CJaUoZSJlsMCFYcsvQod2jUAVA

Appears to be caused by 'jwplayer' triggering html5 video:

<div class="jwplayer aspectMode playlist-none jw-user-inactive" id="product-gallery-player" tabindex="0" style="width: 100%; display: inline-block; opacity: 1; background-color: rgb(0, 0, 0);">

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

As is the one above (html5-video):
https://www.mynotanglebrush.com/?MID=6159551

<div id="video"><div id="video-video1199" class="video-js vjs-default-skin vjs-playing" width="290" height="215" style="width: 290px; height: 215px;">

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

This can now be easily reproduced by loading/importing: lib/test/single-audio-test.json

from adnauseamv1.

dhowe avatar dhowe commented on August 29, 2024

Fixed via a regular expression hack, should revisit this, but closing for now...

from adnauseamv1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.