Comments (9)
In file queue if we will change those line:
...
// Acquire lock on process
self._running++;
if (self.concurrent - self._running > 1) {
// Continue processing until saturated
self._processNextIfAllowed();
}
self._startBatch(batch, tickets, lockId);
});
like this:
...
// Acquire lock on process
self._running++;
self._startBatch(batch, tickets, lockId);
if (self.concurrent - self._running > 1) {
// Continue processing until saturated
self._processNextIfAllowed();
}
});
it will work correctly
from better-queue.
Do you have some code to reproduce the behaviour?
from better-queue.
var Queue = require('better-queue');
var cc = new Queue(mainTaskQueue, {
concurrent: 8,
filo: false,
maxTimeout: 1000,
retryDelay: 100,
maxRetries: 3,
afterProcessDelay: 1,
});
for(let i=0; i<10; i++) {
let task = {nr:i};
cc.push(task);
}
[Output]:
Nr: 6
Nr: 5
Nr: 4
Nr: 3
Nr: 2
Nr: 1
Nr: 0
Nr: 7
Nr: 9
Nr: 8
What I would like to achive and I did by changing line order in your code like I wrote before.
[Output]:
Nr: 0
Nr: 1
Nr: 2
Nr: 3
Nr: 4
Nr: 5
Nr: 6
Nr: 7
Nr: 8
Nr: 9
Your recursive program starts task after checking that another can be started. I think you should start and than check that you can start another one. Also you should think about filo parameter here.
from better-queue.
@GonzoBe I think you need to provide some more code. What's printing the "Nr: ..." string? What's mainTaskQueue
?
from better-queue.
sorry my mistake this is code for print/main job
function mainTaskQueue (task, callback) {
console.log("Nr: "+task.nr);
}
from better-queue.
Fixed in 3.8.8
from better-queue.
thanks ! :D
from better-queue.
@leanderlee 3.8.10 seems like problem is still there
from better-queue.
The code above works for me on node 10/11. Are you on a different node version?
You may you want to check your process fn logic. Concurrent implies running in parallel so if the tasks take different amounts of time then they would finish in a different order. better-queue can only guarantee that they start processing in the order it was given.
from better-queue.
Related Issues (20)
- What is the suggested highest value for concurrent option? HOT 2
- task deleted and re-added on maxTimeout HOT 1
- TypeScript Support HOT 2
- maxRetries is not applied for tasks in the store
- 🐛 Large data in the store caused the app to crash
- How to update file progress?
- How to edit file progress?
- batchSize bigger than 1 => "TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined" HOT 1
- maxTimeout issue?
- Most recent version no longer works with PostgreSQL store?
- It is unclear in readme.md what time uint `getStats().average` is
- Why does `maxTimeout` have no effect on `getStats().average`? HOT 4
- in `on("task_failed", handler)` , when maxTimeout error is emitted, the `error` input must be an error object
- Add CI to GitHub repo HOT 1
- Oversight on task_progress event? HOT 5
- maxRetries is not honored when tasks with same id are pushed into the queue HOT 1
- Delete a task? HOT 3
- Task queue memory leak
- When retry, queue not processed in order HOT 3
- getRunningTask is not defined in the store interface HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from better-queue.