Giter Site home page Giter Site logo

Comments (5)

anopheles avatar anopheles commented on September 15, 2024 5

The limit seems to have changed to a float in https://godoc.org/golang.org/x/time/rate is it possible to update your library to allow floats?
related to #58

from tollbooth.

didip avatar didip commented on September 15, 2024

Just multiply it by 60 to get per minute limit.

from tollbooth.

rebootcode avatar rebootcode commented on September 15, 2024

What do you multiply? Can you please share code. Is this how you do ,

package main

import (
    "github.com/didip/tollbooth"
    "net/http"
    "time"
)

func HelloHandler(w http.ResponseWriter, req *http.Request) {
    w.Write([]byte("Hello, World!"))
}

func main() {
    // Create a request limiter per handler.
    http.Handle("/", tollbooth.LimitFuncHandler(tollbooth.NewLimiter(60, nil), HelloHandler))
    http.ListenAndServe(":12345", nil)
}

but doesn't that mean - 60 request per seond and not 1 request per minute

from tollbooth.

davisdevs avatar davisdevs commented on September 15, 2024

@rebootcode Since max argument for tollbooth.NewLimiter is int64, the lowest you can go is 1 request per second i.e. 60 request per minute, as discussed here. If you urgently need to set lower than 60 request per minute, you have to fork it and modify the max argument to your needs.

from tollbooth.

didip avatar didip commented on September 15, 2024

@rebootcode I see what you want to do... @davis12529 is correct, we are limited to what https://godoc.org/golang.org/x/time/rate can do, and it limits on per second basis.

from tollbooth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.