Comments (5)
The limit seems to have changed to a float in https://godoc.org/golang.org/x/time/rate is it possible to update your library to allow floats?
related to #58
from tollbooth.
Just multiply it by 60 to get per minute limit.
from tollbooth.
What do you multiply? Can you please share code. Is this how you do ,
package main
import (
"github.com/didip/tollbooth"
"net/http"
"time"
)
func HelloHandler(w http.ResponseWriter, req *http.Request) {
w.Write([]byte("Hello, World!"))
}
func main() {
// Create a request limiter per handler.
http.Handle("/", tollbooth.LimitFuncHandler(tollbooth.NewLimiter(60, nil), HelloHandler))
http.ListenAndServe(":12345", nil)
}
but doesn't that mean - 60 request per seond and not 1 request per minute
from tollbooth.
@rebootcode Since max
argument for tollbooth.NewLimiter
is int64, the lowest you can go is 1 request per second i.e. 60 request per minute, as discussed here. If you urgently need to set lower than 60 request per minute, you have to fork it and modify the max
argument to your needs.
from tollbooth.
@rebootcode I see what you want to do... @davis12529 is correct, we are limited to what https://godoc.org/golang.org/x/time/rate can do, and it limits on per second basis.
from tollbooth.
Related Issues (20)
- Question: How to Limit Max Number of Requests Per Hour HOT 2
- Different behavior on limiting based on header key for v4.0.2 and v7 HOT 2
- have some example about params
- Deadlock when calling `GetStatusCode()` in `SetOnLimitReached()` HOT 2
- tollbooth.LimitByKeys限制不住问题
- limit not work as expected
- Add go.mod and go.sum files HOT 2
- Limit by Context value HOT 3
- v5 path
- beego example HOT 2
- question:Can limiter discard the path dimension? HOT 1
- SetOnLimitReached function doesn't seem to execute HOT 1
- v5 pulling in v4 module as well HOT 3
- How can I set 5 limit in 1 minute? HOT 6
- go-cache used for limiter leaking goroutines HOT 2
- Configurable option for using ratelimit standardization proposal HOT 8
- Question: Not grabbing latest changes HOT 5
- SetMethod is not working. HOT 6
- Tollbooth breaks Safari / iOS / iPad / etc. HOT 2
- Token limiting does not work. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tollbooth.