Comments (8)
Man, I keep not getting notified over email.
This does look like a bug. I will take a look at it closer, it has been a while.
from tollbooth.
v4.0.2
from tollbooth.
@didip Yes that's how I see this feature should work, based on the use case I outlined above. Also, this new code still supports the "aggregated limit" use case if needed. Just set the header value to a static value for all users, then it works just like before.
from tollbooth.
I was actually thinking the same; @didip can you please give your comments on this issue?
from tollbooth.
Agreed the headerValues part of the code looks not right. It's not checking the configured values against the request value, and also not using the request value to build the key.
from tollbooth.
This is a legitimate bug, see fix SHA above.
from tollbooth.
@didip For the case of a configured header name with no value, the new code puts the header name into the key but no value. I thought it's supposed to include the header value in the request as part of the key? Or did I misunderstand the intended use case?
Example:
If I want to throttle on a header called X-USER-ID, so that each user is bound by a request limit, this is not going to work with the new code (nor the old code). Only the header name is in the key, so different users coming from the same IP (e.g. behind corporate firewall) would all be subject to the same aggregated limit, not individual limits.
from tollbooth.
@jack-chung If you only define request header (without values) and if everyone visiting has X-USER-ID
, then yes, they all limited under the same bucket.
Do you think they should all be limited as individual limit?
from tollbooth.
Related Issues (20)
- Question: How to Limit Max Number of Requests Per Hour HOT 2
- Different behavior on limiting based on header key for v4.0.2 and v7 HOT 2
- have some example about params
- Deadlock when calling `GetStatusCode()` in `SetOnLimitReached()` HOT 2
- tollbooth.LimitByKeys限制不住问题
- limit not work as expected
- Add go.mod and go.sum files HOT 2
- Limit by Context value HOT 3
- v5 path
- beego example HOT 2
- question:Can limiter discard the path dimension? HOT 1
- SetOnLimitReached function doesn't seem to execute HOT 1
- v5 pulling in v4 module as well HOT 3
- How can I set 5 limit in 1 minute? HOT 6
- go-cache used for limiter leaking goroutines HOT 2
- Configurable option for using ratelimit standardization proposal HOT 8
- Question: Not grabbing latest changes HOT 5
- SetMethod is not working. HOT 6
- Tollbooth breaks Safari / iOS / iPad / etc. HOT 2
- Token limiting does not work. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tollbooth.