Giter Site home page Giter Site logo

Comments (6)

diegohaz avatar diegohaz commented on April 30, 2024

Maybe we need to move injectGlobal to outside the component. I'm not able to test this right now. Can you see if this works?

from arc.

0xsven avatar 0xsven commented on April 30, 2024

I just realised that it adds up with every page refresh

edit: what do you mean with outside of the component?

from arc.

diegohaz avatar diegohaz commented on April 30, 2024

It makes sense. App is mounted on every page refresh. the *Mount methods aren't the right place forinjectGlobal indeed.

from arc.

diegohaz avatar diegohaz commented on April 30, 2024

I mean something like this:

injectGlobal`
body {
margin: 0;
}
`

class App extends Component {
...

from arc.

0xsven avatar 0xsven commented on April 30, 2024

That works!

from arc.

diegohaz avatar diegohaz commented on April 30, 2024

Nice! Would you mind to send a PR with this on master (I merge with other branches later)?

The files are src/components/App.js and src-clean/components/App.js

from arc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.