Please, test generator-arc

[diegohaz]

Please, test generator-arc

[hefox]

Just did "yo arc" then used yo arc:component generate a component and looks to be working fine, will update if not.

(I'm fairly new to react and totally new to arc, but not to using yeoman.)

[kybarg]

Works for me as well

[0xsven]

yo arc:store produces normalizr schema and middleware files? I was expecting the standard arc store from the docs :)

[protoEvangelion]

@diegohaz WOW! This is a super cool utility and is looking great so far. However, I am struggling to get storybook to work.

I chose the universal-redux branch and when I do npm run storybook the UI shows up properly on port 9001 but does not show any components. I am running Windows 10 on Chrome. Here is what it looks like:

I think the problem may be in the generated config file in the .storybook folder. In config.js this statement is throwing an eslint error on the import theme statement:

import configureStore from 'store/configure'
import theme from 'components/themes/default'

In the components folder under the src directory, no themes folder was generated.

Do you think I am on the right track or am I missing something?

[diegohaz]

@protoEvangelion Thank you for the feedback.

We need to copy src/components/App.js and src/components/themes to the src-clean folder.

Do you want to send a PR against the master branch with that change?

[diegohaz]

@0xsven It just copies the current store folders on the boilerplate or on your code. Wasn't this what you expected?

[protoEvangelion]

@diegohaz Sure thing! Just made the PR. By the way, I met Michael Jackson yesterday the creator of React Router and he said they are releasing React Router 4 before React Conf on Monday. When you want to make the switch from version 3 to 4 I would be happy to help :)

[diegohaz]

@protoEvangelion Wow! Good to know that.

ARc had RR4 on the early versions (see v0.2.1 and the v0.3.0 patch notes to understand the reason we downgraded).

Well, since #92 we don't need the scroll management anymore. We could already add RR4 on master today. But for the redux branch, we need to wait for react-router-redux to support RR4 or use another equivalent solution.

On universal-redux and fullstack we need to make sure that RR4 works well with SSR and our fetchData approach (otherwise we should change that approach).

That said, the project was designed this way (separated in branches) so we can handle better this situation. If RR4 works on master, let's do that asap, we can upgrade other branches later (see #112 (comment) where I talk exactly about it).

Your help is very welcome.

[diegohaz]

Just created an issue for RR4 upgrade: #161

[protoEvangelion]

@diegohaz Just an idea, is there any way to make searching case insensitive? For instance, if I search for hero after running yo arc:component nothing will show up. I have to search for Hero for it to show up. Not a big deal but would be cool 👍

[diegohaz]

@protoEvangelion We are using inquirer-autocomplete-prompt here to find components: https://github.com/diegohaz/arc/blob/generator-arc/src/component/index.js#L42-L48

I'm not sure if it has case option though.

EDIT: Ah, actually, we can. We just need to update the .filter logic (probably lowercasing everything).

Something like

choices.filter(choice => choice.name.toLowerCase().indexOf(input.toLowerCase()) >= 0)

should work, but I'm not sure.

[protoEvangelion]

@diegohaz I would be happy to test this, but am unsure how to make that happen in a yeoman enviroment.