Giter Site home page Giter Site logo

Comments (6)

gpspake avatar gpspake commented on May 26, 2024 4

on second though, I guess there aren't any conflicts if we use Grid and Cell

<div class="grid-x">
  <div class="cell">full width cell</div>
  <div class="cell">full width cell</div>
</div>
<div class="grid-x">
  <div class="small-6 cell">6 cells</div>
  <div class="small-6 cell">6 cells</div>
</div>
<div class="grid-x">
  <div class="medium-6 large-4 cell">12/6/4 cells</div>
  <div class="medium-6 large-8 cell">12/6/8 cells</div>
</div>

becomes:

<Grid type="x">
  <Cell>full width cell</Cell>
  <Cell>full width cell</Cell>
</div>
<Grid type="x">
  <Cell small="6">6 cells</Cell>
  <Cell small="6">6 cells</Cell>
</Grid>
<Grid type="x">
  <Cell medium="6" large="4">12/6/4 cells</Cell>
  <Cell medium="6" large="8">12/6/8 cells</Cell>
</Grid>

Thoughts?

from react-foundation.

crisu83 avatar crisu83 commented on May 26, 2024

@gpspake Good idea, but unfortunately I don't have time to work on this right now. Feel free to make a PR for this nevertheless.

from react-foundation.

brentdodell avatar brentdodell commented on May 26, 2024

👍

from react-foundation.

gpspake avatar gpspake commented on May 26, 2024

Does anyone have any thoughts on the best way to go about this; you'd probably want to maintain an option to use the legacy grid, so do you provide some config to avoid naming conflicts? Do you prefix the components with xy?

from react-foundation.

iloginow avatar iloginow commented on May 26, 2024

@gpspake Obviously all that we have to do in order to support the new XY Grid is simply add 2 new components: Grid and Cell. And update the Foundation version to 6.4.0 the package.json file of course. I don't see any possible conflicts whatsoever. I'd love to use Foundation + React as a "Front End Standard" for my projects. And I think this new XY Grid is fantastic so those two components are really missing here. Did you manage to create any of those? Because I'm also interested in helping out.

from react-foundation.

crisu83 avatar crisu83 commented on May 26, 2024

This has been done, thanks to @iloginow.

from react-foundation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.