Giter Site home page Giter Site logo

Comments (4)

digitalcoyote avatar digitalcoyote commented on May 30, 2024 1

I'll be pushing a fix soon. It looks like in early development I left an attribute in the target file that ignored the return value.
<Exec Command="$(NuGetDefenseExe) $(MSBuildProjectFullPath) $(TargetFramework)" IgnoreExitCode="true" />

Changing that to false caused the build to fail in additions to marking the appropriate errors.

from nugetdefense.

jwilliamson1 avatar jwilliamson1 commented on May 30, 2024 1

Thanks @digitalcoyote! I was able to see failures register locally and in my build pipeline. Thanks so much!

from nugetdefense.

digitalcoyote avatar digitalcoyote commented on May 30, 2024

I've reproduced it, I'm about to eat, so it may be just a bit before I get to work on it. Hopefully I'll have a fix up soon after that.

Thanks for reporting this.

EDIT: I had an invalid Blacklist in my test configuration. I have not been able to reproduce this yet.

from nugetdefense.

digitalcoyote avatar digitalcoyote commented on May 30, 2024

Interestingly, it fails in Rider/Visual-Studio, but the sdk returns 0 and states the Build Succeeded. Looking into this.

from nugetdefense.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.