Review break out properties in typings

[digitaltwinconsortium]

Review break out properties in typings

[jrdouceur]

I can't repro this failure. I just ran a simple model through ParseToJson() on the latest preview package (1.0.35-preview-gf7d12847e2) and its output included:

{
  . . .
  "dtmi:test:anInterface;1": {
    . . .
    "contents": {
      "expectedDistance": "dtmi:test:aProperty;1",
      "currentDistance": "dtmi:test:aTelemetry;1",
      "setDistance": "dtmi:test:aCommand;1",
      "proximity": "dtmi:test:aRelationship;1"
    },
    "commands": {
      "setDistance": "dtmi:test:aCommand;1"
    },
    "components": {},
    "properties": {
      "expectedDistance": "dtmi:test:aProperty;1"
    },
    "relationships": {
      "proximity": "dtmi:test:aRelationship;1"
    },
    "telemetries": {
      "currentDistance": "dtmi:test:aTelemetry;1"
    },
    . . .
  },
  . . .
}

[rido-min]

should the new breakout properties reference the concrete interfaces?

from

export interface InterfaceInfo extends EntityInfo {
  EntityKind: 'Interface';
  contents: { [name: string]: string };
  commands: { [name: string]: string };
  components: { [name: string]: string };
  properties: { [name: string]: string };
  relationships: { [name: string]: string };
  telemetries: { [name: string]: string };
  extends: string[];
  extendedBy: string[];
  schemas: string[];
}

to

export interface InterfaceInfo extends EntityInfo {
  EntityKind: 'Interface';
  contents: { [name: string]: ContentInfo };
  commands: { [name: string]: CommandInfo };
  components: { [name: string]: ComponentInfo };
  properties: { [name: string]: PropertyInfo };
  relationships: { [name: string]: RelationshipInfo };
  telemetries: { [name: string]: TelemetryInfo };
  extends: string[];
  extendedBy: string[];
  schemas: string[];
}

[jrdouceur]

The DtdlOm.d.ts file describes the JSON returned by ParseToJson(), which does not return a hierarchical structure. The JSON object that is the value of, e.g., "components" maps name strings to DTMI strings, not to ComponentInfo JSON objects. This is the same for the breakout properties as it is/was for the "contents" property.

[rido-min]

got it.

I'm leaving this issue open until the JS sample is updated to reflect those properties (that will require to populate to full objects)