Comments (4)
Have you tested it on latest air-light version without modifications? Have you figured out what causes it, is it moveTo or something else? 🤔 On Dude website the new Air-light back to top wasn't yet used. The focus should always go to the first focusable element for accessibility reasons. #page is not that.
Have to test this further when I have time. If you have a bulletproof solution to this, feel free to send a PR :)
from air-light.
Doesn't happen on latest air-light. Doesn't work for me on commit 7902d56, but seems to work on 1d770f8 (commit before the latest changes to _accessibility 🤷). I'll try to find the root cause to understand what breaks it.
from air-light.
Problem is caused when moveto tries to get window's (container) pageYOffset, meaning amount of pixels from the top of the screen (how much the user has scrolled), and on Firefox it seems the value being returned is 10 for some reason, and on Chromium it's 0.
When it's 10, this clause returns the move function, because lastYOffset (now being 10 returned by last loop) is smaller currentYOffset. If the value is 0, the "if (lastYOFfset)" clause will not run, because 0 is a nullish value in JavaScript 👍
Because of this I believe some styles made by developers after starting to style the website may cause the scrolling to break.
from air-light.
I have identified why this happens is not 100% moveTo's fault. When the user get's focused to the skip to content link, Firefox places the user 5 pixels scrolled down (margin?).
This can be fixed by focusing the user only after the animation has finished (callback). I'll create a PR
from air-light.
Related Issues (20)
- Make CPT & tax archive titles translatable HOT 1
- JS Error with Keyboard navigation HOT 4
- Remove opinionated colors from the default footer HOT 6
- Fix default theme preview HOT 1
- Cleanup script removes and touches site footer twice HOT 1
- Additional class names HOT 1
- Investigate `pll_translatable` not working properly on taxonomies HOT 1
- Any plans on implementing theme.json? HOT 3
- SVG Ready HOT 1
- Remove root font-size 62.5%
- Anchors smoothing only works if all targets of links before the link exist
- Error: ENOENT: no such file or directory when running gulp HOT 3
- Custom tax from ACF not displaying HOT 2
- Deprecated: Using ${var} in WordPress 6.4.2 HOT 2
- How to enable sticky-nav functionality HOT 1
- No blocks available in page editor HOT 3
- Submenus don't close via their own toggle button on large touch devices HOT 2
- localization.js is getting replaced improperly by createtheme.sh
- Mobile navigation is wrongly offset with WP admin bar
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from air-light.