The roger from digitpaint

Release zips to online location instead of mailing

Automatically build a list of release zips and upload them.

Building on travis yields other output

When building on travis the links to assets are made absolute while locally this doesn't happen?

Can it have something to do with the relativizer?

See CMDA/sss-course@5c46f3a

Simplify partial rendering

There are two issues with partial rendering:

To pass variables you always have to use partial "XYZ", locals: { key: "value" }. That extra locals key is unnecessary.
There are two ways to use locals within the partial. Directly using the locals[] Hash or by using the generated local variables based on the keys in the hash. One method should suffice.

Remove hpricot dependency and replace with something else

HPricot is really old and should be replaced with something like Nokogiri

Use correct mimetypes on *.X.erb files

Roger Middleware should determine the correct mimetype.

Undefined release in relativizer

Yet another without test coverage? 💃

https://github.com/DigitPaint/roger/blob/master/lib/roger/release/processors/url_relativizer.rb#L37

Add plugin generator

Likewise the generator for generators, we should make a plugin generator, make it as seemless as possible to extract additional functionality into a gem.

Listen to ipv4 0.0.0.0

Roger (0.13.0) listens on ipv4 only to 127.0.0.1, but I want to use 0.0.0.0 as well.

release.getfiles also returns directories

In the Roger::Release::Injector class release.getfiles(@options[:into]) is called, see https://github.com/DigitPaint/roger/blob/master/lib/roger/release/injector.rb#L49. I've a mockup and In the mockupfile the injector is called to inject a banner into the pattern **/*.js,**/*.css.

The thing is in a certain mockup I've a JS library file placed at '/vendor/raf.js/raf.min.js', yes that's correct a folder named 'raf.js'. The injector tries to retrieve all the files with this pattern, by calling release.getfiles. This getfiles function uses the glob to get all files and it also founds the folder 'raf.js', because it's not checking/validating wether it's a file. (https://github.com/DigitPaint/roger/blob/master/lib/roger/release.rb#L206). So its missing a check to validate it collects only files at the function 'getfiles'. :)

Another solution could be to exclude the 'vendor' folder for the injector, but the injector doesn't support a exclude/skip array.

If layout is missing no proper warning is yielded

If a layout is missing you don't get any feedback. It just renders without the layout. This should not happen.

Verbose mode is ignored in roger test

Invoking roger test -v to get verbose mode, doesn't currently work.

$ bundle exec roger test -v
ERROR: "roger all" was called with arguments ["-v"]
Usage: "roger all"

Rename Mockupfile to Rogerfile

Rename the class and the preferred filename. Keep support for old Mockupfile but give a warning.

Add roger command to show current version

Right now it's not possible to check which version of roger is used.
So we can execute the command bundle exec roger -v (or --version), and it will display the current version of roger that's used.

Front-Matter data merging in renderer is a bit naïve

Front-Matter data merging is a bit naïve; we just update the data hash everytime we encounter a new front-matter. As all templates are now created equal it means that you can now theoretically put front-matter in partials as well. But as long as you don't everything should work as before.

roger generate new PROJECT_DIR is not working

The flow 'Get started' is not currently working:

$ gem install roger
...
$ roger generate new example
/Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:198:in `rescue in root': Could not locate Gemfile or .bundle/ directory (Bundler::GemfileNotFound)
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:194:in `root'
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:106:in `bundle_path'
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:425:in `configure_gem_home_and_path'
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:92:in `configure'
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:153:in `definition'
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:123:in `setup'
    from /Users/joran/.rvm/gems/ruby-2.2.2@global/gems/bundler-1.10.6/lib/bundler.rb:134:in `require'
    from /Users/joran/.rvm/gems/ruby-2.2.2@example/gems/roger-1.4.6/lib/roger/cli.rb:4:in `<top (required)>'
    from /Users/joran/.rvm/rubies/ruby-2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from /Users/joran/.rvm/rubies/ruby-2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from /Users/joran/.rvm/gems/ruby-2.2.2@example/gems/roger-1.4.6/bin/roger:3:in `<top (required)>'
    from /Users/joran/.rvm/gems/ruby-2.2.2@example/bin/roger:23:in `load'
    from /Users/joran/.rvm/gems/ruby-2.2.2@example/bin/roger:23:in `<main>'
    from /Users/joran/.rvm/gems/ruby-2.2.2@example/bin/ruby_executable_hooks:15:in `eval'
    from /Users/joran/.rvm/gems/ruby-2.2.2@example/bin/ruby_executable_hooks:15:in `<main>'

A workaround is the following:

$ echo "gem 'roger'" > Gemfile
$ roger generate new example

Apparently, there is a misplaced Gemfile check when creating a new project. This check can probably be removed.

`rsync': undefined method `success?' for nil:NilClass

On line: https://github.com/DigitPaint/roger/blob/master/lib/roger/release/finalizers/rsync.rb#L68

CodeClimate coverage
https://codeclimate.com/github/DigitPaint/roger/coverage/5587d85dd86bab7e2601da4d

How is the $CHILD_STATUS set?

Sass files getting processed by Tilt

This causes source mapping using external files to fail, because these files cannot be rendered separately nor should they be (the original source should be returned).

Binary files are passed through the renderer as well (unsure if this is a problem), e.g.:

00:59:10 roger.1 | Rendering template #<Pathname:something.jpg> ("/something.jpg")

I think we can either:

Filter certain extensions here and not pass them to the template renderer
Filter certain extensions inside the resolver to match no files
Solve it in the libsass plugin by having it serve .scss files as well
Unregister Sass from Tilt

Env is undefined in rack/roger

On https://github.com/DigitPaint/roger/blob/master/lib/roger/rack/roger.rb#L46 the env is undefined.

Allow binding of view helpers to the template

Right now, you can attach view helpers by defining them into the global scope which is copied to roger.

I would like to be able to add them with a sane scope.

Git branch finalizer is broken

branch variable isn't passed to commit_and_push_release

Add ability to add layouts and partial via plugins

While this is already possible in the Mockupfile (see below), it should be able to append paths to this array in plugins.

mockup.project.partial_path = [mockup.project.path + "partials", mockup.project.path + "libs/website-shared/partials"]

Rethink changelog and documentation deliverables

The generation of documentation, TOC and changelog that are delivered are still depended on copy-paste from earlier projects. To ease the process, we should reconsider how we work with this. As an artefact of earlier mockup versions we still rely on injecting the changelog, we could leverage Tilt here for example. Currently we lack syntax highlighting for example. This is just an example however, I am interested in the problems people experience while using roger in their workflow.

For the moment I will focus my effort on creating a generate command for these _doc files, however feedback is very appreciated!