Comments (5)
Hummm. That's supposed to be a magic global from ruby. I think the rubocop autocorrector did something to this
On 22 jun. 2015, at 13:45, Edwin van der Graaf [email protected] wrote:
On line: https://github.com/DigitPaint/roger/blob/master/lib/roger/release/finalizers/rsync.rb#L68
CodeClimate coverage
https://codeclimate.com/github/DigitPaint/roger/coverage/5587d85dd86bab7e2601da4dHow is the $CHILD_STATUS set?
β
Reply to this email directly or view it on GitHub.
from roger.
Aye.
306a84b#diff-d12e35b68c9b91f475a6ab3ad7d3b30aL55
- unless $?.success?
- raise RuntimeError, "Rsync failed.\noutput:\n #{output}"
- end
+ fail "Rsync failed.\noutput:\n #{output}" unless $CHILD_STATUS.success?
from roger.
What ruby version does this happen? I tested it in ruby-1.9.3, ruby-2.2.0 and there doesn't seem to be an issue
from roger.
Can you see if the tests in PR #37 branch also break for you?
from roger.
Fixed in #37
from roger.
Related Issues (20)
- Add roger command to show current version HOT 1
- Add ability to add layouts and partial via plugins HOT 2
- Env is undefined in rack/roger HOT 1
- Undefined release in relativizer HOT 2
- Remove the extractor
- release.getfiles also returns directories HOT 3
- Increase test coverage HOT 1
- Allow binding of view helpers to the template HOT 1
- Add NPM/Bower dependencies check HOT 3
- roger generate new PROJECT_DIR is not working
- Git branch finalizer is broken
- Front-Matter data merging in renderer is a bit naΓ―ve
- Renderer#find_partial / Renderer#find_layout has a bit of overlap that could be refactored
- Old files can remain in release folder after roger release HOT 1
- Simplify partial rendering
- Log as JSON
- Release breaks on when using different directory then html for web root
- Remove empty folders in release
- Sass files getting processed by Tilt
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roger.