Giter Site home page Giter Site logo

Comments (7)

dilab avatar dilab commented on July 22, 2024

that sounds like a good idea.

or the better, extract the naming method to a strategy, so we can swap in different strategies for naming the uploaded file.

from resumable.php.

adadgio avatar adadgio commented on July 22, 2024

I have made a PR on that, its now in sync (dilabel there is a last one you need to pull which just includes a isUploadComplete public method and getExtension public method). We can close the issue ! :-)

from resumable.php.

dilab avatar dilab commented on July 22, 2024

@adadgio Will need you to fix the tests before I can merge.

from resumable.php.

adadgio avatar adadgio commented on July 22, 2024

I've commited the fix (+README) but i'm not in the position to unit test right now. Does that fixes the issue ?

Tks

from resumable.php.

georaldc avatar georaldc commented on July 22, 2024

Tests pass with the latest changes from @adadgio

from resumable.php.

adadgio avatar adadgio commented on July 22, 2024

All lights green then : -). @dilab would you be so kind to make a new release when you merge ? Tks.

from resumable.php.

dilab avatar dilab commented on July 22, 2024

@adadgio @georaldc awesome! merged and new tag created.

thanks for the code.

:)

from resumable.php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.