Comments (4)
Hi Romain
Thanks for the efforts.
I did not explicitly disallow PR, you should be able to do that.
Can you double check on your end?
from resumable.php.
Its fine i've done it (forked and created pull request with stable version). You should see the PR now.
I've basically changed only a few stuff inside ::createFileAndDeleteTmp()
if (null !== $this->filename) {
// optionaly create a unique slugified filename
if ($this->filename === static::SLUGIFY) {
$slugify = new Slugify();
$filename = $slugify->slugify($filename);
} else {
// else use user define custom final file name
$filename = $this->createSafeFilename($this->filename, $filename);
}
}
And then all the other stuff is just protected properties for filename and SLUGIFY constant.
Finally added a Slugify class (Helper/Slugify) inside the project.
All right ?
from resumable.php.
Merged. Thanks for the code!
from resumable.php.
Great !
from resumable.php.
Related Issues (20)
- CakePHP Folder.php class issue. HOT 1
- Cannot make it work, error in script HOT 2
- This doesn't work in the latest version ? HOT 3
- Request type detection HOT 1
- SimpleRequest is empty HOT 1
- frontend HOT 7
- mkdir file exists HOT 13
- Update composer package HOT 1
- Server returns 200 when file paths are wrong HOT 1
- Code is not working out of the box HOT 4
- BUG: File large than chunksize, possible corrupt after merging.
- headers and HTTP 1.1 HOT 2
- Resumable is not defined HOT 6
- Monolog HOT 1
- Broke framework compatibility HOT 1
- if the last chunk reach at last it will fail HOT 1
- Composer Install Error HOT 2
- how to override new FileName if FileExist and return Filename as response??? HOT 1
- Security vulnerability - arbitrary file upload anywhere in the file system HOT 7
- Make Contribution HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from resumable.php.