Giter Site home page Giter Site logo

Comments (4)

dilab avatar dilab commented on July 22, 2024

Hi Romain

Thanks for the efforts.

I did not explicitly disallow PR, you should be able to do that.
Can you double check on your end?

from resumable.php.

adadgio avatar adadgio commented on July 22, 2024

Its fine i've done it (forked and created pull request with stable version). You should see the PR now.

I've basically changed only a few stuff inside ::createFileAndDeleteTmp()

if (null !== $this->filename) {
            // optionaly create a unique slugified filename
            if ($this->filename === static::SLUGIFY) {
                $slugify = new Slugify();
                $filename = $slugify->slugify($filename);
            } else {
                // else use user define custom final file name
                $filename = $this->createSafeFilename($this->filename, $filename);
            }
        }

And then all the other stuff is just protected properties for filename and SLUGIFY constant.
Finally added a Slugify class (Helper/Slugify) inside the project.

All right ?

from resumable.php.

dilab avatar dilab commented on July 22, 2024

Merged. Thanks for the code!

from resumable.php.

adadgio avatar adadgio commented on July 22, 2024

Great !

from resumable.php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.