Giter Site home page Giter Site logo

Comments (3)

dillonkearns avatar dillonkearns commented on July 19, 2024

Thanks for the issue @sporto, it's really helpful to see this use case. It appears that non-leading underscores are valid in Elm module names. I'll go ahead and preserve them, and go with the minimal-change normalization strategy we discussed (just move leading underscores to the tail-end, and make sure the first letter's case is correct).

from elm-graphql.

dillonkearns avatar dillonkearns commented on July 19, 2024

Hey @sporto, I published a fix for this and #19.

To make the diff more manageable, I released npm version 2.0.3 with the changes to remove the comments with the version number data and instead use the metadata file, and a separate npm version, 2.1.0, which changes the name normalization strategy. I would recommend doing the 2.0.3 update first to remove some noise from your pull request.

You can see NormalizeTests.elm for examples of how the normalization works.

Let me know how the update goes!

from elm-graphql.

sporto avatar sporto commented on July 19, 2024

This is fixed now, thanks. Closing.

from elm-graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.