(Case 116917) error when changing password for user in french language

[dimagi]

(Case 116917) error when changing password for user in french language

[vladimiroff]

The reason that caused this issue is quite fun. Most of the "real world" languages use some funny symbols. Romanian guys put strange things on top of their characters, some nations decided to go right to left, the nation I'm from decided that latin symbols are overrated so they introduced their own and so on.

But what is the special thing in the french is the question is here? How comes that this issue is available only when using french? Well, they use apostrophes. "User data" in french is "Données d'utilisateur". And this translation is put into:

customDataEditor = uiElement.map_list('{{ couch_user.user_id }}', '{% trans 'User Data' %}');

There are single quotes around the translation of "User Data". So the apostrophe in "Données d'utilisateur" creates syntax error in the javascript. Since the js on the page is now broken, the form is being sent directly by the browser instead of as an asynchronous call (that expected json).

So it's up to you to decide how to fix the issue:

1. Easy way: Just put double quotes there. This particular issue is solved.
2. We could assume that this is not the only place where these apostrophes make things works. How about fixing them all?

If it's up to me, I would go with plan number 2. But that's up to you to decide. Are you okay with the idea of completely forbidding single quotes around trans just because of the french?

P.S.: Almost forgot. @dimagiupdate, ping :)

[czue]

wow, thanks for the investigation @vladimiroff! i think both 1 and 2 are good answers (1 now, 2 as a best practice moving forward). definitely accepting fixes for either :) @dimagiupdate

[millerdev]

👍 great answer