Giter Site home page Giter Site logo

Add support django 3.0 about django-cte HOT 6 CLOSED

dimagi avatar dimagi commented on July 22, 2024 2
Add support django 3.0

from django-cte.

Comments (6)

ryanhiebert avatar ryanhiebert commented on July 22, 2024 1

@jnns: If we're willing to just use .annotations, despite the overhead that it can sometimes have due to making an OrderedDict, it looks like that's been available since Django 1.8: django/django@f59fd15. That seems like the most reasonable course of action there.

I'll make a PR to do that, and then see if I can figure out the other one in reasonable time, although I also am not terribly familiar with the ORM. Thank you for the work you put into it.

from django-cte.

jnns avatar jnns commented on July 22, 2024

I tried to find a solution for this but had to give up as I'm not familiar enough with the ORM. These are my findings:

Since django/django@24b82cd#diff-0edd853580d56db07e4020728d59e193 Query._annotations is available as Query.annotations.

The bigger issue comes with django/django@3543129#diff-0edd853580d56db07e4020728d59e193: tests involving a subquery fail because the selected columns don't use the subquery alias anymore but instead refer to the parent table.

from django-cte.

warmwaffles avatar warmwaffles commented on July 22, 2024

This is preventing us from upgrading to 3.0. Anyone make any progress on this?

from django-cte.

ryanhiebert avatar ryanhiebert commented on July 22, 2024

I haven't been able to make any further progress on this. If someone comes across this, please feel free to take a whack at it. I think it's just 2 tests failing now, but it's doing an incorrect reference for annotated columns, and I haven't fully unpacked why and exactly what is going on.

from django-cte.

ryanhiebert avatar ryanhiebert commented on July 22, 2024

@millerdev : My employer, AspirEDU, is interested in funding the work to get this library working with Django 3.0. Is that something that you'd be willing to discuss? Is so, please send me an email at [email protected], so we can get that conversation going.

from django-cte.

ryanhiebert avatar ryanhiebert commented on July 22, 2024

@millerdev: It won't be possible for us to work through dimagi for this work, because of the minimum contract amount. Might you be willing to work with us directly? If so, would you mind reaching out with a non-Dimagi account, as the contact you pointed me to requested that further discussion in this direction not happen over Dimagi communication channels, such as your dimagi email.

from django-cte.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.