New function `findGuild` to combine cache and getting to avoid undefined

[discordeno]

New function `findGuild` to combine cache and getting to avoid undefined

[MilSci]

also I just realized to avoid always use async/await when calling the function, you can split up the function to establish async await after it knows it can't get it from the cache... I can write the code for this in about an hour

[MilSci]

Refactored:

It now is either going to get it straight from the cache, or if it can't, then rely on async/await to keep efficiency up.

export const findGuild = (guildId: string) => {
  const guild = cache.guilds.get(guildId)
  if(guild) return guild; //Return the guild if its in the cache
  
  const getStructuredGuild = async () => {
    const guildStructure = await getGuild(guildId, true) //Get the guild structure
    const shardID = (BigInt(guildStructure.id) >> 22n) % BigInt(botGatewayData.shards)
    const struct = await structures.createGuild(guildStructure as CreateGuildPayload, Number(shardID)); //If not create the structure and set it in the cache
    cache.guilds.set(struct.id, struct);
    return struct; //return it
  };
  return getStructuredGuild();
};

[itohatweb]

For me this is more a utility function which you don't need unless you do advanced caching/sweeping.

[itohatweb]

I'm not sure when you would need this. In this template all guilds are cached always. There is no such advanced sweeping in there which could cause it to be uncached.

[Skillz4Killz]

@itohatweb I would consider implementing gamers dispatchRequirements here and then perhaps this could be useful