Unclear behaviour for fixed input geometry

[mtazzari]

Unclear behaviour for fixed input geometry

[jeffjennings]

Hey Marco,

Thanks for this. Are you using the version of frank from pip? The current version of master has corrected this by applying the supplied dra/ddec if fit_phase_offset is true and/or applying the supplied inc/pa if fit_inc_pa is true, regardless of the value of type (see the block beginning here).

The type of geometry being applied/fitted for is also printed to the terminal at runtime, including this caveat in the current version of master -- "You requested a Gaussian fit to determine the geometry, but you provided values for inclination, PA, and the phase offset. --> Using your provided values (not fitting for the geometry)".

[jeffjennings]

(This is also why we have the fit_phase_offset and fit_inc_pa arguments in the .json, so that you can fit for neither, or one of them, or both)

[mtazzari]

Hi Jeff, many thanks for the quick check!
I am using the the PyPI version 1.0.1 indeed.
I've seen the updated block, I believe it should fix the issue.
I'll test it and then hopefully close the issue.

We should make a new release then!

#157 will help to release more quickly to PyPI.

[jeffjennings]

Yeah sorry for the bug! I'll open PRs for the last minor things I have this week that I'd like to include in the 1.1.0 release, then finally push that to PyPI.

Awesome re:#157, that would be super helpful!

[jeffjennings]

I've verified the input geometry is handled as expected, so going to close this!