malloc(): invalid size (unsorted) in gcc-10

[divvun]

malloc(): invalid size (unsorted) in gcc-10

[unhammer]

Argh this has been there since 6f7962e – as far back as we can compile without getting older dependencies

[unhammer]

I don't get it with tcmalloc

[flammie]

I don't get this with GCC 10 on gentoo:

cc --version
gcc (Gentoo 10.3.0-r2 p3) 10.3.0
Copyright (C) 2020 Free Software Foundation, Inc.
Dies ist freie Software; die Kopierbedingungen stehen in den Quellen. Es
gibt KEINE Garantie; auch nicht für MARKTGÄNGIGKEIT oder FÜR SPEZIELLE ZWECKE.

... but I'm not sure of tcmalloc, it doesn't show up in configure?

[unhammer]

I often run with LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libtcmalloc_minimal.so.4 which makes some things faster, makes other things break, and makes yet other things confusingly not break.

[unhammer]

Seems like it's in hfst-pmatch, simply doing

hfst_ol::PmatchContainer * t = new hfst_ol::PmatchContainer(instream);

with an std::ifstream instream triggers it

[flammie]

Ah yeah I get it after update of hfst now.
Valground log data

[flammie]

So it's a regression between 3.15.5 and now, this includes: the c++ modernisation stuff, decoupling of foma and openfst and few bug fixes plus lastly some new things in tokenise and pmatch... it doesn't show up in the basic pmatch-functionality-test even with valgrind so there must be some other condition to it too (hfst-pmatch does hfst_ol::PmatchContainer container(instream); in beginning of main)..

[unhammer]

hfst/hfst@eb3da2c not 100% sure I'm testing the same thing

(evidence of my force-pushing in these comments =P)

[unhammer]

the test in hfst works fine if I include config.h, specifically this line:
#define USE_ICU_UNICODE 1

$ g++-10 test_pmatch.cc -DHAVE_CONFIG_H -I../.. -I../../libhfst/src -lhfst -o test_pmatch && ./test_pmatch ; echo $?
loading
loaded
0
$ g++-10 test_pmatch.cc                 -I../.. -I../../libhfst/src -lhfst -o test_pmatch && ./test_pmatch ; echo $?
loading
loaded
free(): invalid pointer
Aborted (core dumped)
134

[unhammer]

So if I configure libdivvun with

./configure   CFLAGS="-DUSE_ICU_UNICODE=1" CXXFLAGS="-DUSE_ICU_UNICODE=1"

it works fine in gcc-10 with regular malloc. But shouldn't that flag only be checked at hfst's compile time? (My hfst is compiled with icu.)

[TinoDidriksen]

Fixed in hfst/hfst@cea8775