Giter Site home page Giter Site logo

Comments (8)

daveisfera avatar daveisfera commented on June 1, 2024 1

Daphne doesn't implement this: https://asgi.readthedocs.io/en/latest/extensions.html#websocket-denial-response.

I'm not sure what this is supposed to mean. The description sounds like it works and I've tested the change in the linked PR and it works

from daphne.

Kludex avatar Kludex commented on June 1, 2024

Daphne doesn't implement this: https://asgi.readthedocs.io/en/latest/extensions.html#websocket-denial-response.

from daphne.

carltongibson avatar carltongibson commented on June 1, 2024

OK, thanks for looking at it @Kludex.

@daveisfera I'm not sure what the problem here really is, or why/how the PR resolves it. Also there's no tests.

I think to progress it would help to step back and explain what the issue is. Then we can think about the appropriate response.

(Sorry if that seems a pain, but I'm slow sometimes, and I like to understand an issue before just merging a proposal. Thanks.)

from daphne.

Kludex avatar Kludex commented on June 1, 2024

The OP wants to send a different status code if the connection is rejected. It can only be done with the WebSocket Denial Response extension.

from daphne.

carltongibson avatar carltongibson commented on June 1, 2024

Ok, so I can have a read.

@daveisfera fancy doing a fuller job here?

from daphne.

Kludex avatar Kludex commented on June 1, 2024

If reference is needed, both Uvicorn and Hypercorn implement the extension.

from daphne.

daveisfera avatar daveisfera commented on June 1, 2024

Honestly, I've moved onto a different approach, so if you're not interested in resolving this issue, then you can just close this

from daphne.

carltongibson avatar carltongibson commented on June 1, 2024

Ok, thanks for the input. I'll have a read about the extension anyhow.

from daphne.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.