Giter Site home page Giter Site logo

Comments (4)

claudep avatar claudep commented on May 16, 2024

I pushed the patch to remove warnings about string arguments to url(). I've not investigated much about the patterns deprecation, but I don't know if there is an easy way to get rid of them while keeping compatibility with pre-1.8 Django.

from django-contrib-comments.

collinanderson avatar collinanderson commented on May 16, 2024

Easy: using a list works just fine in 1.4+ at long as you have it wrapped in url()

from django-contrib-comments.

claudep avatar claudep commented on May 16, 2024

I forgot the url() wrapping, thanks Collin!

from django-contrib-comments.

claudep avatar claudep commented on May 16, 2024

There are some remaining warnings in the test suite, but will be easier to remove after we drop Django 1.6. The main code should be warning free. Thanks for the report.

from django-contrib-comments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.