Field of CharField inheritance

[claudep]

Field of CharField inheritance

[benkonrath]

I suspect this is an oversight. I vaguely recall noticing this in the past but assumed that these fields were intentionally setup to inherit directly from Field. Since there's a specific issue with this setup, I think we should change all text based fields to inherit from CharField.

I think it's worthwhile to make a 3.1.1 release to address this. Do you see any compatibility issues with this change?

[benkonrath]

I can make a PR later this afternoon if you haven't already beat me to it.

[claudep]

Such changes could always give backwards incompatibilities, however, I think it's the right thing to do, and we can document the affected fields in the ChangeLog. I'll be pleased to review your patch :-)

[benkonrath]

There were more than I thought there would be and I have to do other stuff now. I'll finish the PR in the next couple of days and let you know when it's ready for review.

[claudep]

Sure, no rush! Just tell me if you'd like some help to cook the patches.

[benkonrath]

I can do it - it's giving me more motivation to finish my work on a Django wrapper to python-stdnum and possibly/eventually deprecate most of this stuff. :-)

[claudep]

Fixed by d7ba69b