Giter Site home page Giter Site logo

Comments (6)

nemesifier avatar nemesifier commented on August 15, 2024

Test needed, could you send a pull request with one?

from django-hstore.

dczech avatar dczech commented on August 15, 2024

OK, I am preparing PR with fix. I can split it into 2 commits (test & fix). Fix is pretty easy:
in django_hstore/query.py line 127

elif lookup_type in ['contains', 'icontains']:
.... #add this case
elif lookup_type == 'isnull':
    return super(HStoreWhereNode, self).make_atom(child, qn, connection)
#end patch
else:
...

from django-hstore.

nemesifier avatar nemesifier commented on August 15, 2024

i've just created a branch issues/null-filtering, please open 1 pull request to that branch and push commits as soon as you have them, me and @niwibe will look into it as soon as we have some free time

from django-hstore.

dczech avatar dczech commented on August 15, 2024

I need help, did PR but into wrong branch. Could you advise how can I fix that?

from django-hstore.

nemesifier avatar nemesifier commented on August 15, 2024

ok not a big deal for me, let's wait for @niwibe 's input

from django-hstore.

niwinz avatar niwinz commented on August 15, 2024

No problem for me for pull request to master, I review it this afternoon and merge it. Seems very simple patch ;)

@nemesisdesign if you believe that the patch is ready, you can merge it without my review ;)

Thanks to both!

from django-hstore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.