ColumnPresenceChecker is incompatible with Rails' new default `belongs_to` validation behavior

[agrobbin]

ColumnPresenceChecker is incompatible with Rails' new default `belongs_to` validation behavior

[djezzzl]

Hi there 👋

First, thank you both for using the gem and reporting the issue!

The idea that @chaadow has suggested seems reasonable here. Even though it may bring false positives (in cases with custom if: :something), at least we will have less noise now. Also, it's worth adding that covering this case is "nice to have" rather than a critical issue (like missing unique indexes).

There is also a way to patch ActiveRecord to "mark" those presence validators with this optimized "if" condition. As the database_consistency runner is expected to run as a separate process on demand, we can do that without affecting other environments (development/production/test, etc). However, maintaining it could be slightly more complicated and unwelcome.

With that said, I would go with this proposal by chaadow.

Would you mind creating a PR? I would be happy to merge it and release it ASAP.

P.S. It would be good to add one more check to your condition that the ActiveRecord's version is 7.1+

P.P.S. And again, thank you, @chaadow and @agrobbin! Sorry for being late.

[djezzzl]

Released in 1.7.21!

Thank you again! Have a great week!

[chaadow]

@djezzzl @agrobbin I made this little "quick fix" which made all my belongs_to pass with rails 7.1 defaults
chaadow@2270738

haven't tested backward compatibility. but if you can take a look maybe I can create a PR with this change

[chaadow]

HI @djezzzl Unfortunately this checker fails in rails 7.1 ( which was released about a week ago )

[agrobbin]

At first glance it seems like a reasonable guess, but I'll defer to @djezzzl here, as I'm not sure if that's "safe enough".