djfm/cssin

A CSS inliner in PHP that works pretty well

cssin's Issues

CSSTidy version is old (PHP7 issue)

Hello,

CSSIn uses CSSTidy which is almost ten year-old (see http://csstidy.sourceforge.net, last version 1.3 from 2007).
It is a problem with PHP7, since a lot of "deprecated" message appears.

Hopefully, development continued here: https://github.com/Cerdic/CSSTidy

Can you update to latest CSSTidy ? Thanks.

CSSIN-inlineCSS() call takes 8 sec on my Core I 5 server

As you can see

InlineCSS() takes 73%(8 sec) of all my script
InlineCSS() calls
1)parseCSS(41.99 %)
2)simple_dom_data->find(25 %) (may be http://ru2.php.net/manual/en/book.dom.php can be used ?)

parseCSS() calls csstidy->parse(38.67%)

csstidy->is_token is called 33084 times !

Uninitialized string offset: -1

inline_css/vendor/csstidy/class.csstidy.php[878]

The problem is

cssin_helper.php(127): csstidy->parse('@charset "UTF-8...')

Switch to an FSF or OSI-approved free software license

I'd like to use this with CiviCRM, but the license for cssin is too vague. Have you considered switching to a GPL-compatible license?

FSF approved licenses: https://gnu.org/licenses/license-list.html#SoftwareLicenses
OSI approved licenses: http://opensource.org/licenses/alphabetical

css not cached?

The getCSS function says it caches the files but I believe it needs to refer to self::cssFiles rather than just $cssFiles for this to be true - it seems to be just using a locally scoped non-static var

    if(!isset($cssFiles[$url]))
    {
        $cssFiles[$url] = file_get_contents($url);
    }
    return $cssFiles[$url];

https://github.com/djfm/cssin/blob/master/src/CSSIN.php#L32