Please set the default newrelic license attribute value to BLANK ('') or do not define it at all

[et304383]

Please set the default newrelic license attribute value to BLANK ('') or do not define it at all

[djoos]

Hi @eric-tucker,

thanks for getting in touch! Sorry for the inconvenience the CHANGE_ME-changes have caused...

What about setting default['newrelic']['license'] to nil by default, instead of a random string (eg. "CHANGE_ME" or "REPLACE_WITH_REAL_KEY")?

Let me know what you think!

Kind regards,
David

[et304383]

Something that is consistent and will not change.

To be honest, it should be nil by default so that I can set default values in a wrapper cookbook without having to use force_default as that prevents me from setting it in an environment file without using override.

If you leave node.newrelic.license at nil (undefined) that is the safest bet. Just don't set it at all. I want default[:newrelic][:license] = 'something' to work in a wrapper cookbook.

[djoos]

+1 (will push these changes to master shortly)

[et304383]

This is better and more consistent, but does force me to use force_default if I want to override in a wrapper cookbook (or I just set in environment files).

When I said nil by default, I actually meant undefined. As in no value if I referenced the hash using that index.

That being said, as long as there are no plans to change it again, I'm fine with this. Number one priority is consistency. :)

[djoos]

Hi @eric-tucker,

there shouldn't be any need to use force_default when specifying the license attribute's value via...

default_attributes(
{
    "newrelic" => {
        "license" => "yournrlicensekey"
    }
})

...in either a role or environment.

Re: plans to change it again
The only reason why I changed it from CHANGE_ME was that for some reason nrsysmond restarted just fine on Ubuntu when running tests without setting the license key. It failed when using the "REPLACE_WITH_REAL_KEY". Anyway, the current default value (nil) is not going to change anymore ;-)

Hope this helps!

Kind regards,
David

[et304383]

Yup. force_default, however, is reserved for overriding in a wrapper cookbook where the wrapped cookbook set the value.

For now, I get by with checking for nil and overriding in the environment when I want it to be set. The reason I'm so concerned with this is I want to install newrelic automatically just by setting the value [away from the default]. Probably not a good practice, but I'd rather have that instant flexibility where my run list doesn't need to change: I just need to set an attribute to install newrelic.

[djoos]

Ah ok, in that case: the default license-attribute will be (and will stay) nil :-)

Hope this helps!