Comments (5)
The library seems to be the only reason this exists:
class Chef
class Recipe
def get_newrelic_license(type)
if node['newrelic']['use_vault']
chef_vault_item(node['newrelic']['data_bag'], node['newrelic']['data_bag_item'])[type]
else
node['newrelic'][type]['license']
end
end
end
end
Every agent recipe sets license
as a variable pointing to get_newrelic_license(type)
.
@djoos - Can that just be removed in favor of setting license = node['newrelic']['license']
?
from newrelic.
+1 to removing the Chef Vault library. I feel like this functionality should come from a wrapper recipe/cookbook and that application cookbooks should be agnostic.
from newrelic.
Hi guys,
thanks for getting in touch!
The version of the newrelic-cookbook (currently 0.6.0, but will probably get released as 1.0.0) does have #54 (@csteward87) included.
I see your point and even though only having merged that particular PR, it seems that this functionality should be out of the scope of the newrelic-cookbook and should belong in a wrapper cookbook instead...
Do let me know your thoughts!
Kind regards,
David
from newrelic.
FYI: I've just pushed 8249dda which has the chef-vault support taken out of the cookbook, together with some meetme-plugin tweaks...
HTH!
from newrelic.
@djoos Thanks!
from newrelic.
Related Issues (20)
- Newrelic dot APM agent doesnot upgrade HOT 4
- doesn't support strip_command_line parameter HOT 2
- Every node attribute used a default value to a property needs a `lazy { }` around it. HOT 6
- Cannot overwrite windows newrelic-infra agent source HOT 1
- Cloning resource attributes for service[newrelic-daemon] from prior resource HOT 1
- [agent_dotnet] Add support for enabling distributed tracing on the newrelic.config.erb template HOT 1
- Error executing action `enable` on resource 'newrelic_agent_infrastructure[Install]' is failing on debian7
- Default value of 'windows_checksum' in newrelic/resources/agent_infrastructure.rb does not match computed checksum HOT 1
- Recipe newrelic::java_agent fails install with the `Error executing action run on resource execute[newrelic_install_newrelic.jar]` HOT 2
- hello-world
- Hi world HOT 1
- Distributed Tracing feature in PHP Agent cookbook doesn't work
- add max_procs for newrelic_infra.yml
- Saleem A. H
- Compile Error on server_monitor.rb HOT 2
- "platform?" bug after ugprading newrelic version HOT 2
- Adding add event_queue_depth attribute to newrelic-infra.yml file is not there
- Cookbook failed on chef-client 17.8.25 HOT 2
- Hello World
- Please add Ubuntu 22.04 support, Ubuntu 20.04 fails with malformed repository line
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newrelic.