Giter Site home page Giter Site logo

Comments (4)

djpugh avatar djpugh commented on September 17, 2024

Thanks @hvasbath - I'll need to refamiliarise myself with the formulation as I haven't actually been working in this space for a while to double check - but I believe the difference is because in MTfit the 6 vector is ordered as:
Mxx
Myy
Mzz
sqrt(2)*Mxy
sqrt(2)*Mxz
sqrt(2)*Myz

While in the paper it is ordered as (for consistency with Chapman (?) IIRC)
Mxx
Myy
Mzz
sqrt(2)*Myz
sqrt(2)*Mxz
sqrt(2)*Mxy

Plus there is some expansion of double angles as well
I've added some comments to the code in the PR #67 - please could you check that it makes sense to you - i will try and double check later after work as well

from mtfit.

hvasbath avatar hvasbath commented on September 17, 2024

Hi @djpugh ,

thanks a lot for the clarification! The double-angles hint resolves everyhing, but I wonder why you do that, because numerically its two times faster to calculate sin(2x) instead of 2sin(x)cos(x).

from mtfit.

djpugh avatar djpugh commented on September 17, 2024

TBH, I can't remember why, it's a good point (in fact should probably cache the cos and sin values - I think because it is a one off calculation per run, I probably didn't focus on it

from mtfit.

hvasbath avatar hvasbath commented on September 17, 2024

FYI, was testing eq A7-A9 against A15-A17.
Found the error. Its in equation A2 Appendix A.
Must be in third component -sin(take-off angles) instead of sin(take-off angles). Its just a typo comparing to Aki and RIchards.
Again thanks a lot!

from mtfit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.