0.3.0 JS issue

[dramalho]

0.3.0 JS issue

[dkniffin]

Ah yeah.... 🤦 I meant to switch the POST request to dragend but forgot. I think it's actually bad UX as-is and the change should only apply when the mouse button is released.

I'll work on that soon.

[dramalho]

looks good, the UI still does the little bit where if the horizontal size is small enough and I drag the lines just slightly it starts to endlessly swap rows, but as no network requests are generated this is less of a problem

I'll push this to production, thaaaaaaaaaaaaank you Derek ❤️

[dkniffin]

@dramalho Interesting. Thank you for reporting and investigating. In my testing, I hadn't tested the index as: :reorderable_table version.

I'll add that to the test suite now and change the querySelectorAll(".aa-reorderable") to querySelectorAll("table.aa-reorderable") and see if that resolves it. If it does, I'll push a patch version w/ the fix

[dramalho]

Yeah, that should fix it, it's really just a specific JS issue, I just wanted to run it by you in case I was missing something super obvious

thank you Derek 🫶

[dkniffin]

@dramalho I fixed it and pushed a v0.3.1. Can you test it and let me know if it resolves the issue for you?

[dramalho]

ok, re: the original issue, it's great, things are working again but -- I am noticing something new though :) (sorry man, I know this is annoying)

So, if I drag (but don't release the button, or don't release it quick enough) I notice it gets stuck in a look on that dragover handler and keeps swapping lines very quickly, each time initiating a reorder request

Unsure if the actual network request should be done at dragend ?

[dramalho]

this is a new issue though, want me to open a new one?

[dramalho]

(in the meantime let me try on safari - this was chrome)

[dramalho]

ahh the wonderful world of frontend dev, safari / firefox are fine, chrome is doing machine gun requests 😭

[dramalho]

Ok, kinda hard to replicate but I get the same behaviour in Safari as well -- best bet is horizontal size, especially when the index table that AA generates starts to get compressed (< 900px for this particular screen I'm looking at) -- the rows start to flip between each other and because the network request is there (and not when we release the button) it machine guns the server

I know the previous version only acted on the drag when we released the row, one option might be to update the UI on dragover but shoot the network request on dragend ?

[dkniffin]

@dramalho Done. Give 0.3.2 a try

[dramalho]

Third time's a charm!!! I'll test it now 👏