Dealing with imported types

[janwirth]

Dealing with imported types

[dkodaj]

Sry for the late reply, forgot to watch the repo.

Finding types imported from the app's own modules should not be too hard, we just need to parse the imports. I'll check if some parts of impfix can be reused here.

Types imported from external packages are trickier. E.g. if you import Math.Vector3.Vec3, then decgen should find your copy of elm-explorations/linear-algebra and figure out what to do with it.

[janwirth]

Hey any updates? How can I assist?

[dkodaj]

Impfix can grab the imports; after that, we only need to feed imported modules to decgen and look for type definitions as needed. Help is most welcome on that front, but first I'll have to update impfix to 0.19 and incorporate elm-parser.

[janwirth]

I am using impfix on large 0.19 codebases without issue. Maybe we can use a temporary solution where impfix jsut streams file contents and we can keep impfix like it is?

[dkodaj]

Sure, if you're keen to have this working asap. I'll start rewriting decgen and I'll make suggestions about modifying the cli js.

…

On Tue, Jul 16, 2019 at 4:22 PM Jan Wirth ***@***.***> wrote: I am using impfix on large 0.19 codebases without issue. Maybe we can use a temporary solution where impfix jsut streams file contents and we can keep impfix like it is? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=AGTGN7YLPL4AQZ5BVWR2Y7LP7XKSHA5CNFSM4H5OQFQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2BAOTY#issuecomment-511838031>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGTGN75UHKIEF723NE5JITDP7XKSHANCNFSM4H5OQFQQ> .

[janwirth]

My plan is to use decgen in https://github.com/FranzSkuffka/iso-elm for the transport layer.

But please do not stress yourself. Let us think about what would create the most value. Maybe we can re-use some code of or contribute to elm-in-elm/compiler. Maybe we can have a call or so to think about what the best strategy is?

[janwirth]

Here are the test-suites for the parser: https://github.com/elm-in-elm/compiler/blob/master/tests/ParserTest.elm

[dkodaj]

Thanks for the links, your project sounds interesting. Updating is no stress at all, but give me a few days pls.

[dkodaj]

I created a branch named “imports” for this feature. The generator now expects a list of strings. The head is the main module and the tail are the dependencies. The cli takes two arguments, the name of the main module and the (relative) directory where the module is (defaults to cwd).

There's a simple test you can run with

$ node src/decgen.js ExampleMain.elm

Probably buggy though!

[janwirth]

Very cool!