Feature request: Support for resolver label in prometheus logger

[dmachard]

Feature request: Support for resolver label in prometheus logger

[dmachard]

by the way, feel free to make a pull request :)

[dmachard]

The stream_id contains the name of your resolver identity (with dnstap collect), it's not sufficient?

[flz]

Maybe I misunderstand what QueryIP and ResponseIP are then.

My use case is to deploy the dns-sniffer (not dnstap) collector on a bunch of machines and get client-side DNS metrics. I don't necessarily control what resolvers they use through /etc/resolv.conf and being able to have per-resolver latency metrics for example gives me better visibility over resolver performance.

Hope this helps!

[dmachard]

The queryip is the source IP of the client and response IP should be the IP of the resolver.

2022-09-26T14:13:09.261751412Z denis-laptop CLIENT_QUERY NOERROR 192.168.1.17 46767 8.8.8.8 53 INET UDP 54b www.google.fr A 0.000000
2022-09-26T14:13:09.278427556Z denis-laptop CLIENT_RESPONSE NOERROR 192.168.1.17 46767 8.8.8.8 53 INET UDP 58b www.google.fr A 0.016676

I can add a new setting parameter to add the label for response IP (but not enabled by default ,you're right)

[flz]

I'll try and take a stab at it when I get a chance. I haven't had to write golang code (yet) :-)

[dmachard]

implemented in release v0.35