Giter Site home page Giter Site logo

Comments (10)

tomasg2012 avatar tomasg2012 commented on August 25, 2024

Sorry, I read the wrong property in this context and answered you incorrectly, let me look into this property and give you a more accurate response.

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on August 25, 2024

After I misunderstood the question, I realized this is a completely different issue of understanding how inheritance works between types. There is a higher version of Boot "v1_1_0" in the Namespace you specified, but because there is no such Property "Boot" in that Namespace that has a BaseType of Boot inside of "v1_1_0", such as "ComputerSystem.v1_1_0.Boot", instead it is only aware of the Property with BaseType "ComputerSystem.v1_0_0.Boot" within that Namespace.

Due to the navigation issue present in the Interop tool, I will be constructing a much more robust tree that should have the ability to alleviate this issue through parental checking.

from redfish-service-validator.

jbobzin-insyde avatar jbobzin-insyde commented on August 25, 2024

How are you doing with this one? I am also seeing this on
Chassis.v1_2_0.Links.Storage
I get
ERROR - Links.Storage: Appears to be an extra property (check inheritance or casing?)
which I think is same failure as System.v1_1_0.Boot.BootSourceOverrideMode

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on August 25, 2024

Raineri brought up an interesting spec definition that was finalized just this May that Complex objects and Resources should contain an @odata.type, such that it would nullify this issue. (This version is 1.2.0) However, considering backwards compatibility is necessary, the program should still attempt to check for a higher type and inherit from it. The issue is still under work.

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on August 25, 2024

This should be fixed in the new pull, which collaborates the highest type available and polls for ComplexType changes (as of now, just Complex).

from redfish-service-validator.

jbobzin-insyde avatar jbobzin-insyde commented on August 25, 2024

The false "extra property error" with ComputerSystem.Boot.BootSourceOverrideMode and Chassis.v1_2_0.Links.Storage are still seen after the recent pull.

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on August 25, 2024

I apologize, seems that I made the mistake in assuming Schemas, as described in Schema tags in a CSDL file, have a "BaseType". However, it is the EntityType inside the Schemas that have BaseTypes that point to earlier EntityTypes, the current method doesn't actually check types lower than the current one.

It's a simple fix, but I'm not sure which of two approaches is more accurate:

  1. List all Schema in the CSDL file and check every version at/below the current Namespace.
  2. Check the current Namespace, and use the BaseType of the Entity inside the Namespace to traverse to a lower type.

from redfish-service-validator.

mraineri avatar mraineri commented on August 25, 2024

Option 2 should be the more appropriate one. With the way we version our namespaces, it's the reliable method.

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on August 25, 2024

This should be in the branch 'enhancements-06-12' now. If you would like to give it a try before Thursday, it would be appreciated, sorry for the oversight.

from redfish-service-validator.

jbobzin-insyde avatar jbobzin-insyde commented on August 25, 2024

fixed in the latest branch

from redfish-service-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.