Giter Site home page Giter Site logo

Comments (5)

tomasg2012 avatar tomasg2012 commented on July 3, 2024

This sounds perfectly reasonable, I actually just encountered this just before this issue was posted, as my setup used ServiceMode but had no hard drive schema to fall back to in the scenario you just described.

In terms of the current implementation, it should be an easy fix.

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on July 3, 2024

As an aside though, metadata doesn't normally describe every single necessary reference for the server... by default it only references the resources that are able to be GET. Am I mistaken?

This would be an issue for some Thermal items I believe, off the top of my head I cannot place what specifically.

from redfish-service-validator.

jbobzin-insyde avatar jbobzin-insyde commented on July 3, 2024

No in previous discussions it was confirmed that $metadata has to supply Uri for schema defining every type actually used or Validator should throw an error. Reference to a type in included Schema, without definition in any Schema file in $metadata, but never used in JSON should be a warning event as this is not actually fatal to client.

Myself I think the Uri inside the Schema files are a feature of Odata that Redfish does not really embrace fully. And these internal-to-schema reference Uri cause more trouble than benefit.

What should Validator do if the Uri inside a schema points to a file with xml content different from the Uri to the same name at $metadata ? This is currently allowed and can lead to very odd inconsistent behavior and tough bugs.

But that is just my opinion.

from redfish-service-validator.

tomasg2012 avatar tomasg2012 commented on July 3, 2024

That is true, I've noticed differences between two different XML files that could cause issues. I will address this for Thursday.

from redfish-service-validator.

mraineri avatar mraineri commented on July 3, 2024

PR merged

from redfish-service-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.