Skip/mute YouTube ads?

[ryankupk]

Skip/mute YouTube ads?

[skupjoe]

I thought that this wasn't working either until I checked the conf and set these to true as well.

This should be part of the CLI setup!

[ryankupk]

I checked the config.json file in the data directory and switched mute_ads and skip_ads from false to true, did some quick testing and actually didn't get any skippable ads but the ads I did get were muted, so seems like that fixes it. But, should this be part of the config wizard? I set this up with the cli and there wasn't a prompt for muting or skipping ads. Should this issue be an enhancement to add that? I'm not sure if it works in the textual wizard as I wasn't able to get that to work but maybe there just needs to be parity between the two if so, or be added to both. Unless I'm missing something entirely

[dmunozv04]

@ryankupk thanks for closing the issue. I’ll release a new version in the near future so this change is on the ‘latest’ tag on docker and on pypi

[ryankupk]

Thanks @dmunozv04, I hope I didn't mess up your workflow or anything. I just came back to the repo because I was going to raise a PR for the minimum skip segment, saw that there was a PR for it already so dropped a comment referencing this issue/PR, saw that this was still open so I closed it since the PR was merged. I didn't know if you were planning to close after making a new release or something so apologies if me closing it was annoying.

[dmunozv04]

No problem, I honestly kinda forgot this issue was still here. Thanks for closing it