FromStr trait support + Parse fractions

[dnsl48]

FromStr trait support + Parse fractions

[dnsl48]

Hi @scott-wilson, thank you for your feedback and for the suggestion!
Yes, indeed, we don't have support for "1/2", although that feels rather trivial to split in two integers and, perhaps, might even use Rust own built-in string to integer parsing capabilities.
Nonetheless, it might be nice to have a shortcut for that in the library API, especially that it is the format we produce via Display. If you have an interest in providing a PR for that, that would be appreciated!

using nom for parsing the string

Yes, nom is a powerful tool. We only have rather trivial parsing in this crate, so I don't feel a strong need to use it, but if you provided the implementation in your PRs, that would be nice (ideally a separate PR with refactoring and a separate one for parsing "1/2"). For the refactored code I would appreciate having a benchmark as well, to make sure we don't have a performance regression.

[scott-wilson]

Sounds good. I'll take a crack at it and see how it benchmarks.

[dnsl48]

Thank you for the contribution!
Released in 0.10.0.

P.S.
Regarding refactoring that with nom it feels like it might not be worth pulling nom to only cover our existing parsing needs. Having nom as a hard dependency could cause version conflicts with external projects' own nom.
Feels like maybe the benefits won't outweigh the downsides in that case.
Closing this issue for now, but please reopen if you'd like to keep that discussion going :)

[scott-wilson]

Yeah, I feel like you're right. Thanks for the merge!