Giter Site home page Giter Site logo

Comments (8)

beardicus avatar beardicus commented on July 30, 2024

Any other ideas?

from cloud_haiku.

ltagliaferri avatar ltagliaferri commented on July 30, 2024

This sounds good to me. I think going forward we can just indicate that contributors use <br> tags to make it more straightforward for folks rather than giving them options. What do you think?

from cloud_haiku.

ltagliaferri avatar ltagliaferri commented on July 30, 2024

Do you think I should update the README so that folks should just use the <br> tag at the end of line breaks? That may make the testing easier and Lyn's Hacktoberfest video uses the tags.

from cloud_haiku.

beardicus avatar beardicus commented on July 30, 2024

Yeah, I think that'd be good.

from cloud_haiku.

ltagliaferri avatar ltagliaferri commented on July 30, 2024

Also... Code of Conduct 😄

from cloud_haiku.

jsoref avatar jsoref commented on July 30, 2024

You're running out of time before "next Hacktoberfest" 😉 unless you mean 2021 at this point. (Might I suggest you update the issue summary to specify a specific year?)

#430 covers updating .gitignore to specifically save from naive package-lock.json adds.

https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github
Has:

If you are looking to recursively add all changes including those in subdirectories, you can type the command git add -A or alternatively git add -all sic s.b. --all for all new files to be staged.

Someone should talk about git config user.name and git config user.email. A number of the commit authors have managed to create amusing values (I'm by far the worst offender, but I'm trying to do that, they presumably aren't.)

For 2021, please replace master with main or similar.

In https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github#create-a-new-branch it'd be nice if instead of new-branch the branch name was some-feature or similar. Yes, people are creating branches, but that's already explained, it's better to hint at good naming by including feature or similar in the example.

WRT CoC, please make sure to fill in all the fields. On my todo list is to file bugs against dozens (hundreds? I can't recall) of repositories whose CoC includes a contact of fill in your contact address here to report violations... 🤦 .

from cloud_haiku.

jsoref avatar jsoref commented on July 30, 2024

073b2ad added <br>s to the sample (it'd be nice if this was in the description w/ a checkbox so someone could mark it as done...)

from cloud_haiku.

jsoref avatar jsoref commented on July 30, 2024

btw, https://github.com/do-community/cloud_haiku/labels?q=hacktoberfest-accepted:

Accept for hacktoberfest, will merge later

That should read:

Accepted for hacktoberfest, will merge later

(And yes, I'm aware you have a video of adding this thing, it's still ok to improve your content and set better examples for others going forward.)

from cloud_haiku.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.